Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagating EnableUnsecuredResponse while cloning #3692

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Propagating EnableUnsecuredResponse while cloning #3692

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
258dd36
Propagating EnableUnsecuredResponse while cloning
maheshnlrb Jun 18, 2019
a776b7b
Fixed formatting in copy constructor
mconnew Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Propagating EnableUnsecuredResponse while cloning
  • Loading branch information
@maheshnlrb
maheshnlrb committed Jun 18, 2019
commit 258dd36515ece16eb41039a20faaf78b7dd16424
2 changes: 2 additions & 0 deletions src/System.Private.ServiceModel/src/System/ServiceModel/Channels/SecurityBindingElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ internal SecurityBindingElement(SecurityBindingElement elementToBeCloned)
LocalClientSettings = elementToBeCloned.LocalClientSettings.Clone();
MaxReceivedMessageSize = elementToBeCloned.MaxReceivedMessageSize;
ReaderQuotas = elementToBeCloned.ReaderQuotas;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've added an extra blank line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NM, I just fixed it in your PR. I'll merge as soon as it passes the tests.

EnableUnsecuredResponse = elementToBeCloned.EnableUnsecuredResponse;
}

public SupportingTokenParameters EndpointSupportingTokenParameters { get; }
Expand Down