-
Notifications
You must be signed in to change notification settings - Fork 572
change link to new label for up-for-grabs #1827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@borsna, It will cover your contributions to all .NET Foundation-managed open source projects. |
@borsna, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @borsna.
@StephenBonikowsky, is our CI build of "OuterLoop Ubuntu14.04 Debug" broken somehow? Not related to this PR. |
Not from our part (that I've been able to figure out), they seem to fail regularly and will eventually pass on re-running. I can follow-up with infrastructure team to see if this is common with other repos as well or just us. |
Thanks @StephenBonikowsky. Yes, please follow up so we make sure we don't miss something. |
@@ -17,7 +17,7 @@ We use GitHub labels on our issues in order to classify them. We have the follo | |||
* [test bug](https://github.com/dotnet/wcf/labels/test%20bug) is a label we assign to all issues related to testing. We label these further with "infrastructure" (for test infrastructure changes) or "enhancement" (for missing tests or those that need enhancement). | |||
|
|||
**Ownership**: These labels are used to specify who owns specific issue. Issues without an ownership tag are still considered "up for discussion" and haven't been approved yet. We have the following different types of ownership: | |||
* [up for grabs](https://github.com/dotnet/wcf/labels/up%20for%20grabs): Small sections of work which we believe are well scoped. These sorts of issues are a good place to start if you are new. Anyone is free to work on these issues. | |||
* [up for grabs](https://github.com/dotnet/wcf/labels/up-for-grabs): Small sections of work which we believe are well scoped. These sorts of issues are a good place to start if you are new. Anyone is free to work on these issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the visible name also to "up-for-grabs" (replace spaces with -) to provide unified clarity.
@@ -17,7 +17,7 @@ We use GitHub labels on our issues in order to classify them. We have the follo | |||
* [test bug](https://github.com/dotnet/wcf/labels/test%20bug) is a label we assign to all issues related to testing. We label these further with "infrastructure" (for test infrastructure changes) or "enhancement" (for missing tests or those that need enhancement). | |||
|
|||
**Ownership**: These labels are used to specify who owns specific issue. Issues without an ownership tag are still considered "up for discussion" and haven't been approved yet. We have the following different types of ownership: | |||
* [up for grabs](https://github.com/dotnet/wcf/labels/up%20for%20grabs): Small sections of work which we believe are well scoped. These sorts of issues are a good place to start if you are new. Anyone is free to work on these issues. | |||
* [up for grabs](https://github.com/dotnet/wcf/labels/up-for-grabs): Small sections of work which we believe are well scoped. These sorts of issues are a good place to start if you are new. Anyone is free to work on these issues. | |||
* [feature approved](https://github.com/dotnet/wcf/labels/feature%20approved): Larger scale issues. Like up for grabs, anyone is free to work on these issues, but they may be trickier or require more work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change "up for grabs" to up-for-grabs
I missed it's merged already. I made the changes here: 1f343b2 |
see dotnet/corefx#17533