Unify logging commands under csharp.collectLogs#9032
Merged
Conversation
JoeRobich
commented
Feb 26, 2026
| "command": "csharp.collectLogs", | ||
| "title": "%command.csharp.collectLogs%", | ||
| "category": "CSharp", | ||
| "enablement": "isWorkspaceTrusted && (dotnet.server.activationContext == 'Roslyn' || dotnet.server.activationContext == 'RoslynDevKit')" |
Member
Author
There was a problem hiding this comment.
When the C#DK provides dump collection with their logging, we can disable this command when running with C#DK.
Suggested change
| "enablement": "isWorkspaceTrusted && (dotnet.server.activationContext == 'Roslyn' || dotnet.server.activationContext == 'RoslynDevKit')" | |
| "enablement": "isWorkspaceTrusted && dotnet.server.activationContext == 'Roslyn'" |
dibarbet
reviewed
Feb 26, 2026
| } | ||
|
|
||
| if (gcDump) { | ||
| progress.report({ |
Member
There was a problem hiding this comment.
A decent amount of mostly duplicative for these various collect options - could consider unifying into a a helper
Member
Author
There was a problem hiding this comment.
The progress reporting and tool acquisition is going away in a follow up.
JoeRobich
commented
Mar 2, 2026
This was referenced Mar 2, 2026
dibarbet
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines the 3 logging commands into a single command which always captures the current log files. The user will be prompted to choose additional log sources like: Record Activity, Performance Trace, Memory Dump, and GC Dump. When dumps are combined with recording activity or a trace then they are taken before and after the recording.