Skip to content

Report when the client LSP is fully initialized #7998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Report when the client LSP is fully initialized #7998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lsptoolshost/server/roslynLanguageServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ export class RoslynLanguageServer {
state: ServerState.Started,
workspaceLabel: this.workspaceDisplayName(),
});
this._telemetryReporter.sendTelemetryEvent(TelemetryEventNames.ClientServerReady);
} else if (state.newState === State.Stopped) {
this._languageServerEvents.onServerStateChangeEmitter.fire({
state: ServerState.Stopped,
Expand Down Expand Up @@ -338,7 +339,7 @@ export class RoslynLanguageServer {
* Returns whether or not the underlying LSP server is running or not.
*/
public isRunning(): boolean {
return this._languageClient.state === State.Running;
return this._languageClient.isRunning();
}

/**
Expand Down
8 changes: 8 additions & 0 deletions src/shared/telemetryEventNames.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,17 @@ export enum TelemetryEventNames {
CSharpActivated = 'CSharpActivated',

// Events related to the roslyn language server.

// Roslyn client has started initialization process.
ClientInitialize = 'roslyn/clientInitialize',
// Roslyn client has started the server initialization process.
ClientServerStart = 'roslyn/clientServerInitialize',
// Roslyn client has acquired the runtime needed to start the server.
AcquiredRuntime = 'roslyn/acquiredRuntime',
// Roslyn client has successfully started the server process.
LaunchedServer = 'roslyn/launchedServer',
// Roslyn client has connected to the server process named pipe.
ClientConnected = 'roslyn/clientConnected',
// Roslyn client and server have fully initialized via LSP.
ClientServerReady = 'roslyn/clientServerReady',
}