Do not remove documents if they are not files #7607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dibarbet could you take a look? I'm not sure if schema checking is the best way to do this or if there are schemes I might be missing |
dibarbet
reviewed
Sep 26, 2024
| // Out of workspace files should be removed once they're closed | ||
| this.removeDocument(uri); | ||
| // Documents that are files should be removed if they are outside the workspace folder | ||
| if (uri.scheme === 'file') { |
There was a problem hiding this comment.
it depends - do you need to close non file documents? Other non-file documents that I know of
- Documents just created, but not saved
- Diff window files
There was a problem hiding this comment.
Diff window files should also not cause us to remove. It looks like we don't track documents that are just created but not saved.
dibarbet
approved these changes
Sep 26, 2024
|
@dotnet-policy-service rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#2261836
When the preview changes window closes, it issues a document closed for a document being tracked but with a URI of 'vscode-bulkeditpreview-editor'. This is a valid notification for closing a document but it should not be removed because that will cause the content to be lost making the client and server out of sync for what it thinks the csharp/html code is