Pass a semicolon-delimited list of files excluded from VS Code.

[rchande]

Fixes #1990

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@8b02101). Click here to learn what that means.
The diff coverage is 60%.

@@            Coverage Diff            @@
##             master    #2171   +/-   ##
=========================================
  Coverage          ?   88.72%           
=========================================
  Files             ?       59           
  Lines             ?     1587           
  Branches          ?       89           
=========================================
  Hits              ?     1408           
  Misses            ?      168           
  Partials          ?       11

Flag	Coverage Δ
#integration	100% <ø> (?)
#unit	88.72% <60%> (?)

Impacted Files	Coverage Δ
src/omnisharp/options.ts	89.23% <60%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b02101...9117912. Read the comment docs.

[TheRealPiotrP]

Can we make the list an array instead of a string? This will be easier for users to edit, to diff..

[TheRealPiotrP]

Also, a test would be useful :)

[TheRealPiotrP]

And are the files consisting of relative paths? Relative to what? What happens if I switch launch targets?

[rchande]

@TheRealPiotrP

Can we make the list an array instead of a string? This will be easier for users to edit, to diff..

Users define this data by editing artifacts in their repo or in vs code settings. The string generated here will be passed to O# as a command line arg. Arguably, it could be json, but that's not very user-friendly for anyone invoking o# outside of the C# extension.

And are the files consisting of relative paths? Relative to what? What happens if I switch launch targets?

They're paths relative to the workspace root. Maybe there's some normalizing we need to do if the working directory for o# isn't the workspace root.

Also, a test would be useful :)

Ok fine :)

[filipw]

Since OmniSharp now has built in support for globbing, and that is exposed over the standard OmniSharp configuration system, you should use that instead, instead of creating custom arguments. Then things will just work automatically, without any other changes required.

OmniSharp allows overriding of its configuration if you pass the args like this:

omnisharp {any other args} fileOptions:excludeSearchPatterns:0=**/foo/**/* fileOptions:excludeSearchPatterns:1=**/bar/**/*

Note that this exact approach is already used for passing formatting options when starting OmniSharp from the extension.

[filipw]

actually, based on my own comment here OmniSharp/omnisharp-roslyn#1161 (comment) you should pass those settings as fileOptions: systemExcludeSearchPatterns not fileOptions:excludeSearchPatterns as that would allow the users to still incorporate their own exclusions via env variables or omnisharp.json

[firelizzard18]

Is this still being worked?

[akshita31]

cc @rchande

[kvalev]

@rchande Do you have the time to finalize this PR? If not I can give it a go.

[rchande]

@kvalev Thanks for the ping.
@filipw I've implemented your suggestion to use the normal omnisharp configuration mechanism. Any other feedback?

[Blackbaud-MitchellThomas]

I am interested in this feature. We want to turn on the system diagnostics but want to exclude certain generated code.

[filipw]

LGTM! sorry for the delay, I somehow missed your message 😀
just needs the conflict resolution and it should be good to go

[WeAthFoLD]

Is this still being worked on? It would be a very useful feature.

[rchande]

Better late than never, this is ready to merge.