Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JsonSerializerOptions to allow trailing commas #53

Merged
merged 1 commit into from
May 4, 2021

Conversation

Youssef1313
Copy link
Member

This allows having trailing commas in dotnet-versionsweeper.json, so when dotnet-versionsweeper.json is updated with new entries, the diff is cleaner.


Before

A diff would look like:

{
    "ignore":[
-        "Entry1"
+        "Entry1",
+        "Entry2"
    ]
}

After

A diff would look like:

{
    "ignore":[
        "Entry1",
+       "Entry2",
    ]
}

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

@IEvangelist IEvangelist added the enhancement New feature or request label May 4, 2021
@IEvangelist IEvangelist self-assigned this May 4, 2021
@IEvangelist IEvangelist merged commit 5e6ab8b into dotnet:main May 4, 2021
@Youssef1313 Youssef1313 deleted the patch-2 branch May 4, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants