We build for NetMinimum when not in source build so target that #9045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
approved these changes
May 20, 2025
ViktorHofer
reviewed
May 20, 2025
| @@ -128,7 +128,7 @@ extends: | |||
| displayName: Install latest daily .NET version | |||
|
|
|||
| - bash: > | |||
| $(Build.SourcesDirectory)/.dotnet/dotnet $(Build.SourcesDirectory)/artifacts/bin/Microsoft.TemplateSearch.TemplateDiscovery/Debug/net10.0/Microsoft.TemplateSearch.TemplateDiscovery.dll --basePath $(System.DefaultWorkingDirectory)/NugetDownloadDirectory --allowPreviewPacks -v --test --diff $(EnableDiffMode) | |||
| $(Build.SourcesDirectory)/.dotnet/dotnet $(Build.SourcesDirectory)/artifacts/bin/Microsoft.TemplateSearch.TemplateDiscovery/Debug/net8.0/Microsoft.TemplateSearch.TemplateDiscovery.dll --basePath $(System.DefaultWorkingDirectory)/NugetDownloadDirectory --allowPreviewPacks -v --test --diff $(EnableDiffMode) | |||
There was a problem hiding this comment.
Thanks for fixing this. I see a few low cost solutions to avoid the hard coded TFM:
- Use
dotnet runto build and run the application without supplying a TFM value (my preferred solution) - Set
AppendTargetFrameworkToOutputPathfalse in the project. Feels hacky to me.
MiYanni
approved these changes
May 20, 2025
|
Let me get this merged to unblock the pipeline and then I'll explore options for making it more resilient in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search cache was broken by Fix tasks not loading on .NET Framework by ViktorHofer · Pull Request #8952 · dotnet/templating