Proper use of Stream.Read(buffer, offset, count) in the TemplateEngine.Core #3420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlada-shubina
changed the title
vlada-shubina
force-pushed
the
stream-read-fix
branch
from
8353e22 to
248dbae
Compare
bekir-ozturk
suggested changes
Jul 9, 2021
| int totalBytesRead = 0; | ||
| if (!_isStream1Depleted) | ||
| { | ||
| while (totalBytesRead < count) |
There was a problem hiding this comment.
I suggest we do partial reads here and leave handling this to the caller, just like any other streams.
There was a problem hiding this comment.
let's delay it when tests on InlineMarkupConditional (where CombinedStream is used) are written. I prefer to have keep implementation as is for now.
test/Microsoft.TemplateEngine.Core.UnitTests/ChunkStreamReadTests.cs
Outdated
Show resolved
Hide resolved
vlada-shubina
force-pushed
the
stream-read-fix
branch
from
248dbae to
51ca6df
Compare
bekir-ozturk
approved these changes
Jul 9, 2021
vlada-shubina
force-pushed
the
stream-read-fix
branch
3 times, most recently
from
6cf1122 to
1778339
Compare
vlada-shubina
force-pushed
the
stream-read-fix
branch
from
1778339 to
1ef0d4b
Compare
vlada-shubina
force-pushed
the
stream-read-fix
branch
from
1ef0d4b to
16d0ec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fixes #3325
The cause of the issue is: dotnet/runtime#53502, dotnet/docs#24649.
Solution
Affected code:
ProcessorState- reading from stream in a loop until buffer is filled; added unit and integration testsCombinedStream- reading from stream in a loop until count is reached; added unit testsInclude- reading from stream in a loop until count is reachedMemoryStream.ToArray()insteadIncludeis not covered with tests: extracted to #3438Checks:
#nullable enableto all the modified files ? - partially