Fix Linux package path issue and add validation tasks in pipeline #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use .NET ZipFile API instead of Compress-Archive to ensure forward-slash paths in NuGet packages (fixes #1213) - Add sourceAnalysisPool config for SDL analysis on Windows - Add ValidateLinux stage to verify packages work on Linux Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Instead of just checking ZIP entry paths, now validates packages by: - Creating a test .NET console project - Installing Microsoft.Spark package via dotnet add package - Building and running the project to verify DLLs load correctly This tests the real-world scenario that was failing on Linux/Mac. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Verify NuGet package signatures using dotnet nuget verify - Validate Authenticode signatures on DLLs inside packages - Validate Authenticode signatures on Worker executables - Display detailed signature info (subject, issuer, thumbprint, validity) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Install osslsigncode for Authenticode verification on Linux - Display certificate details: Subject, Issuer, Serial, Valid From/To - Check timestamp information - Verify signatures on DLLs in NuGet packages - Verify signatures on Worker executables in tar.gz archives Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Load System.IO.Compression assembly before System.IO.Compression.FileSystem to ensure ZipArchiveMode enum is available. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Strip leading whitespace from heredoc/here-string content that was being included due to YAML indentation: - Linux: Pipe heredoc through sed to remove leading spaces - Windows: Use regex replacement to strip leading spaces Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use local nuget.config file instead of global dotnet nuget add source to properly configure the LocalPackages source path. The global source was not being found during package restore. - Linux: Use printf to create nuget.config with proper XML structure - Windows: Build nuget.config string with concatenation to avoid YAML here-string issues Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Linux: Consolidate 4 validation tasks into 2 (Package Installation and Load, Create and Run Test) - Windows: Split 1 monolithic task into 2 matching tasks - Add structured summary table for signature validation output on both platforms - Display file name, status, and signer in formatted table with totals Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
SparkSnail
changed the title
SparkSnail
changed the title
Contributor
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The previous verification used exit code which fails on trust chain issues. Now checks for signature presence (certificate info) rather than full trust verification, since ESRP-signed packages may fail trust verification on Linux agents that don't have Microsoft's root certificate trusted. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test