Skip to content

GHES Raw URL Format Incorrect #1225

Open

Description

@grochoge

Using Github Enterprise Server 3.9.6 with Microsoft.SourceLink.GitHub 8.0.0.

SourceLink is using the /raw path on the main GitHub URL when it should be using the raw. subdomain.

Example of the URL generated:
https://github.INTERNAL_URL/raw/ORG_URL/REPO_URL/1e045336c6c208f216b8e2b2cbb3036a6f4ab41f/CPlusPlusProject/CPlusPlusProject.cpp

Should be:
https://raw.github.INTERNAL_URL/ORG_URL/REPO_URL/1e045336c6c208f216b8e2b2cbb3036a6f4ab41f/CPlusPlusProject/CPlusPlusProject.cpp

GitHub Enterprise Servers can be configured either way, but GitHub recommends using sub-domains for isolation. I'm not sure if there's a way to detect which is actually in use. I would imagine a DNS lookup to see if the raw. domain exists would be sufficient.

Activity

  1. tmat commented on Mar 25, 2024

    @tmat
    Member

    You might be able to configure this in your project (or Directory.Build.props file in the root to apply to all projects) like so:

     <ItemGroup>
        <SourceLinkGitHubHost Include="github.INTERNAL_URL" ContentUrl="https://raw.github.INTERNAL_URL"/>
      </ItemGroup>
    
  2. cliffchapmanrbx commented on Apr 24, 2024

    @cliffchapmanrbx

    We have several thousand repositories on our GitHub Enterprise Server instance, configuring it across all of them will be a bit difficult to coordinate. I'm uncertain if there is any way to know the raw url config without making network requests, which would generally break determinism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions