fixup tagGrepQuery #3725
Merged
fixup tagGrepQuery #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-didyk
requested review from
MichaelSimons,
premun and
mthalman
as code owners
premun
approved these changes
Nov 7, 2023
omajid
reviewed
Nov 7, 2023
| @@ -160,7 +160,7 @@ stages: | |||
| # 083b8b9fe09d04205e87bca0b378e4a3ad74a239 refs/tags/v8.0.0-rc.1.23419.4 | |||
| # 113d797bc90104bb4f1cc51e1a462cf3d4ef18fc refs/tags/v8.0.0-rc.1.23419.4^{} | |||
| # We want to match on both. | |||
| tagGrepQuery="refs/tags/$tag_name\(^{}\)\?$" | |||
| tagGrepQuery="refs/tags/$tag_name\(\^{}\)\?$" | |||
|
|
|||
| echo "git ls-remote --tags destination | grep -q $tagGrepQuery" | |||
There was a problem hiding this comment.
Sorry for the random drive by comment: if you ever see SIGPIPE or broken pipe errors, these grep -q calls might be the culprit. grep -q closes the input pipe as soon as it finds a match, so if the first command (git) is still trying to send some input, it will exit with that broken pipe error.
There was a problem hiding this comment.
Thank you for the pointer! Our validation builds caught this issue almost instantly and your comment saved us a good chunk of time investigating it.
Tried to fix it in #3731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue found by https://dev.azure.com/dnceng/internal/_git/dotnet-release/pullRequest/35064#1699280994
During porting the changes introduced by #3716 to internal project discovered a small issue with the
tagGrepQueryregex, specifically an un-escaped symbol.Fix tested in internal project - https://dev.azure.com/dnceng/internal/_git/dotnet-release/pullrequest/35064