Use our Microsoft.Diagnostics.NETCore.Client, not prebuilt #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I think the reason this regressed (it worked initially: #1824 (comment)) is that the 5.0 GA upgrade PR enabled a flag that forces all repos to build a stable version. That bumped us off the hard-coded version. |
dseefeld
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We build
Microsoft.Diagnostics.NETCore.Client/0.2.0thanks to #1824. Add a patch to dotnet/vstest to use the version from the PVP file rather than the hard-coded0.2.0-preview.20419.2.