-
Notifications
You must be signed in to change notification settings - Fork 136
Always build portable runtime in addition to non-portable. #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
60c221a
First attempt at always having portable.
crummel 617cd42
Make portable build before non-portable.
crummel b4a2cde
Use conditions on portable dependencies
crummel f0f0c6f
Add portable versions to Version.Details.xml so we get git commit inf…
crummel 305e074
Move GatherBuiltPackages after targets import so we override it, and …
crummel 5e25e8e
ILAsm/ILDasm aren't produced in the always-portable proj.
crummel 56f0a98
Only want these to build on Linux
crummel d5e6d49
Try not to break things for ARM.
crummel f02b33b
Add an override for people who don't want to spend the extra time to …
crummel 37aa616
Exclude symbol packages to cut down on space requirements.
crummel 4098dce
Up some timeouts for additional builds
crummel fc2619d
More disk space logging
crummel dbf4140
Try converting to common props for CoreCLR
crummel 1869145
Move built SDKs out of common
crummel 885fbbc
Factor out CoreFX common props
crummel d6a2401
Factor out common core-setup properties
crummel ad2bbed
fix missing quote
crummel 6797c5f
another typo
crummel 6136333
Think we might be cleaning too early
crummel e0a7f27
Fix target name
crummel 5c3a9eb
More target fixes
crummel 757c751
more targets
crummel 6e17ec2
Fix properties
crummel 309c7ad
Think we might need this
crummel 22b7883
Try a different approach
crummel 284bea2
Seems like these can run in either order.
crummel 273700b
Revert "Seems like these can run in either order."
crummel 0c703da
This needs to run for both portable and non-portable
crummel ad84114
These are also shared
crummel a491b63
Fix some RID issues
crummel 8d77bed
CopyPackage needs PackageOutputList to be set.
crummel 920675a
More targets that can run in multiple orders.
crummel cfeec5f
Try with just this
crummel 04d15cb
Package gets skipped
crummel bfefb64
More fun timing differences on CI vs local
crummel 10b6573
Both?
crummel 50d5f2c
Debugging
crummel a798c0a
Can't override global properties
crummel 54f154b
empty is not the same as false
crummel cfad564
Same pattern
crummel b85a1a2
Try shallow clone and more agressive deletions
crummel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<PropertyGroup> | ||
<SourceDirectory>core-setup</SourceDirectory> | ||
<PortableBuild>true</PortableBuild> | ||
<BuildingPortableRuntime>true</BuildingPortableRuntime> | ||
</PropertyGroup> | ||
|
||
<Import Project="core-setup.common.props" /> | ||
|
||
<ItemGroup> | ||
<RepositoryReference Include="coreclr" /> | ||
<RepositoryReference Include="corefx" /> | ||
<RepositoryReference Include="newtonsoft-json" /> | ||
<RepositoryReference Include="newtonsoft-json901" /> | ||
<RepositoryReference Include="roslyn" /> | ||
<RepositoryReference Include="standard" /> | ||
</ItemGroup> | ||
|
||
<Target Name="CleanupRepoForNonPortableBuild" AfterTargets="RemoveBuiltPackagesFromCache"> | ||
<ItemGroup> | ||
<DirsToDelete Include="$(ProjectDirectory)artifacts" Condition="Exists('$(ProjectDirectory)artifacts')" /> | ||
<DirsToDelete Include="$(ProjectDirectory)bin" Condition="Exists('$(ProjectDirectory)bin')" /> | ||
</ItemGroup> | ||
|
||
<RemoveDir Directories="@(DirsToDelete)" /> | ||
</Target> | ||
|
||
<Import Project="core-setup.common.targets" /> | ||
|
||
<Target Name="GatherBuiltPackages" BeforeTargets="CopyPackage"> | ||
<ItemGroup> | ||
<_BuiltPackages Include="$(ShippingPackagesOutput)/*linux*nupkg" Exclude="$(ShippingPackagesOutput)/*.symbols.nupkg" /> | ||
<_BuiltPackages Include="$(NonShippingPackagesOutput)/*linux*nupkg" Exclude="$(NonShippingPackagesOutput)/*.symbols.nupkg" /> | ||
</ItemGroup> | ||
</Target> | ||
</Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))/dir.props" /> | ||
|
||
<PropertyGroup> | ||
<!-- core-sdk always wants a portable runtime on OSX and FreeBSD--> | ||
<OverrideTargetRid>$(TargetRid)</OverrideTargetRid> | ||
<OverrideTargetRid Condition="'$(TargetOS)' == 'OSX'">osx-x64</OverrideTargetRid> | ||
<OverrideTargetRid Condition="'$(TargetOS)' == 'FreeBSD'">freebsd-x64</OverrideTargetRid> | ||
<OverrideTargetRid Condition="'$(TargetOS)' == 'Linux' and ('$(PortableBuild)' == 'true' or '$(BuildingPortableRuntime)' == 'true')">linux-$(Platform)</OverrideTargetRid> | ||
<OverridePortable>$(PortableBuild)</OverridePortable> | ||
<OverridePortable Condition="'$(TargetOS)' == 'OSX' or '$(TargetOS)' == 'FreeBSD'">true</OverridePortable> | ||
<OverridePortable Condition="'$(BuildingPortableRuntime)' == 'true'">true</OverridePortable> | ||
|
||
<BuildArguments>$(FlagParameterPrefix)restore $(FlagParameterPrefix)build</BuildArguments> | ||
<BuildArguments>$(BuildArguments) $(FlagParameterPrefix)configuration $(Configuration)</BuildArguments> | ||
<BuildArguments>$(BuildArguments) $(FlagParameterPrefix)ci</BuildArguments> | ||
<BuildArguments>$(BuildArguments) /p:PortableBuild=$(OverridePortable)</BuildArguments> | ||
<BuildArguments Condition="$(Platform.Contains('arm')) AND '$(BuildArchitecture)' != 'arm64'">$(BuildArguments) /p:TargetArchitecture=$(Platform) /p:DisableCrossgen=true /p:CrossBuild=true</BuildArguments> | ||
<BuildArguments>$(BuildArguments) /p:BuildDebPackage=false</BuildArguments> | ||
<BuildArguments>$(BuildArguments) /p:BuildAllPackages=true</BuildArguments> | ||
<BuildArguments>$(BuildArguments) /p:RestoreAllBuildRids=false</BuildArguments> | ||
<BuildArguments>$(BuildArguments) /p:OutputRid=$(OverrideTargetRid)</BuildArguments> | ||
<BuildArguments>$(BuildArguments) /p:DotNetOutputBlobFeedDir=$(SourceBuiltBlobFeedDir)</BuildArguments> | ||
<BuildArguments>$(BuildArguments) /m:1</BuildArguments> | ||
|
||
<LogVerbosityOptOut>true</LogVerbosityOptOut> | ||
<BuildArguments>$(BuildArguments) $(FlagParameterPrefix)verbosity $(LogVerbosity)</BuildArguments> | ||
<BuildArguments>$(BuildArguments) $(FlagParameterPrefix)binaryLog</BuildArguments> | ||
<BuildArguments>$(BuildArguments) $(FlagParameterPrefix)warnAsError $(ArcadeFalseBoolBuildArg)</BuildArguments> | ||
<BuildArguments>$(BuildArguments) $(FlagParameterPrefix)nodereuse $(ArcadeFalseBoolBuildArg)</BuildArguments> | ||
|
||
<BuildCommand>$(ProjectDirectory)/build$(ShellExtension) $(BuildArguments)</BuildCommand> | ||
<BuildCommand Condition="$(Platform.Contains('arm')) AND '$(BuildArchitecture)' != 'arm64'">$(ArmEnvironmentVariables) $(BuildCommand)</BuildCommand> | ||
|
||
<OutputPlacementRepoApiImplemented>false</OutputPlacementRepoApiImplemented> | ||
<ShippingPackagesOutput>$(ProjectDirectory)artifacts/packages/$(Configuration)/Shipping/</ShippingPackagesOutput> | ||
<NonShippingPackagesOutput>$(ProjectDirectory)artifacts/packages/$(Configuration)/NonShipping/</NonShippingPackagesOutput> | ||
|
||
<NuGetConfigFile>$(ProjectDirectory)/NuGet.config</NuGetConfigFile> | ||
<DependencyVersionInputRepoApiImplemented>true</DependencyVersionInputRepoApiImplemented> | ||
|
||
<EnvironmentRestoreSources>$(SourceBuiltPackagesPath)</EnvironmentRestoreSources> | ||
<EnvironmentRestoreSources>$(EnvironmentRestoreSources)%3B$(ShippingPackagesOutput)</EnvironmentRestoreSources> | ||
<EnvironmentRestoreSources>$(EnvironmentRestoreSources)%3B$(NonShippingPackagesOutput)</EnvironmentRestoreSources> | ||
<EnvironmentRestoreSources Condition="'$(OfflineBuild)' == 'true'">$(EnvironmentRestoreSources)%3B$(ReferencePackagesDir)%3B$(PrebuiltPackagesPath)</EnvironmentRestoreSources> | ||
<EnvironmentRestoreSources Condition="'$(OfflineBuild)' != 'true'">$(EnvironmentRestoreSources)%3Bhttps://api.nuget.org/v3/index.json</EnvironmentRestoreSources> | ||
<EnvironmentRestoreSources Condition="'$(OfflineBuild)' != 'true'">$(EnvironmentRestoreSources)%3Bhttps://dotnetfeed.blob.core.windows.net/dotnet-core/index.json</EnvironmentRestoreSources> | ||
<EnvironmentRestoreSources Condition="'$(OfflineBuild)' != 'true'">$(EnvironmentRestoreSources)%3Bhttps://dotnetfeed.blob.core.windows.net/dotnet-tools-internal/index.json</EnvironmentRestoreSources> | ||
|
||
<!-- core-setup does not destabilize for intermediate servicing builds --> | ||
<IsStable>true</IsStable> | ||
</PropertyGroup> | ||
|
||
<ItemGroup> | ||
<UseSourceBuiltSdkOverride Include="@(ArcadeSdkOverride)" /> | ||
<UseSourceBuiltSdkOverride Include="@(ArcadePackagingOverride)" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<EnvironmentVariables Include="RestoreSources=$(EnvironmentRestoreSources)" /> | ||
<EnvironmentVariables Include="BuildInParallel=false" /> | ||
</ItemGroup> | ||
|
||
</Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
|
||
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))/dir.targets" /> | ||
|
||
<UsingTask AssemblyFile="$(XPlatSourceBuildTasksAssembly)" TaskName="PublishCoreSetupBinaries" /> | ||
|
||
<!-- Need to "publish" the tarballs for cli, until cli respects the assets blob --> | ||
<Target Name="PublishBinaries" AfterTargets="Package"> | ||
<ItemGroup> | ||
<CoreSetupTarballs Include="$(SourceBuiltAssetsDir)dotnet-runtime-*$(TarBallExtension)" /> | ||
<CoreSetupTarballs Include="$(SourceBuiltAssetsDir)dotnet-hostfxr-*$(TarBallExtension)" /> | ||
</ItemGroup> | ||
<PublishCoreSetupBinaries Binaries="@(CoreSetupTarballs)" | ||
DestinationFolderTemplate="$(SourceBuiltRuntimeDir){version}/" > | ||
<Output TaskParameter="PublishedVersion" PropertyName="PublishedVersion" /> | ||
</PublishCoreSetupBinaries> | ||
<Message Text="Published core-setup binaries version $(PublishedVersion)" Importance="High" /> | ||
</Target> | ||
|
||
<Target Name="CopyBinariesToBinFolder" AfterTargets="PublishBinaries"> | ||
<ItemGroup> | ||
<_builtRuntimePackages Include="$(SourceBuiltAssetsDir)*.symbols.nupkg" /> | ||
<_builtRuntimePackages> | ||
<TransformedFileName>$([System.String]::Copy('%(FileName)').Replace('symbols', 'nupkg'))</TransformedFileName> | ||
</_builtRuntimePackages> | ||
<BinariesToCopy Include="$(SourceBuiltAssetsDir)*.*" Exclude="$(SourceBuiltAssetsDir)*.nupkg;$(SourceBuiltAssetsDir)*.requires_nupkg_signing" /> | ||
<BinariesToCopy Include="@(_builtRuntimePackages->'$(SourceBuiltPackagesPath)%(TransformedFileName)')" /> | ||
</ItemGroup> | ||
|
||
<Copy SourceFiles="@(BinariesToCopy)" | ||
DestinationFolder="$(OutputPath)runtime" | ||
Condition="'@(BinariesToCopy)'!=''" /> | ||
</Target> | ||
|
||
<Target Name="SetOutputList" AfterTargets="RepoBuild"> | ||
<ItemGroup> | ||
<PackagesOutputList Include="$(ShippingPackagesOutput)" /> | ||
<PackagesOutputList Include="$(NonShippingPackagesOutput)" /> | ||
</ItemGroup> | ||
</Target> | ||
|
||
</Project> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.