VMR Stage 2 Builds Failing in Arcade with Obsolete Reference

[ellahathaway]

The latest run of the VMR is failing stage 2 builds with the following error:

/vmr/src/arcade/src/Microsoft.DotNet.SignTool/src/VerifySignatures.cs(104,42): error SYSLIB0057: 'X509Certificate.CreateFromSignedFile(string)' is obsolete: 'Loading certificate data through the constructor or Import is obsolete. Use X509CertificateLoader instead to load certificates.' (https://aka.ms/dotnet-warnings/SYSLIB0057) [/vmr/src/arcade/src/Microsoft.DotNet.SignTool/Microsoft.DotNet.SignTool.csproj::TargetFramework=net9.0]
##[error]/vmr/src/arcade/src/Microsoft.DotNet.SignTool/src/VerifySignatures.cs(104,42): error SYSLIB0057: (NETCORE_ENGINEERING_TELEMETRY=Build) 'X509Certificate.CreateFromSignedFile(string)' is obsolete: 'Loading certificate data through the constructor or Import is obsolete. Use X509CertificateLoader instead to load certificates.' (https://aka.ms/dotnet-warnings/SYSLIB0057)

This error is the result of these changes being brought in by dotnet/sdk#41988.

We need to update the code in arcade/src/Microsoft.DotNet.SignTool/src/VerifySignatures.cs to remove the obsolete reference.

[ellahathaway]

From dotnet/docs#41662:

If you are loading X.509 content, X509CertificateLoader.LoadCertificate and X509CertificateLoader.LoadCertificateFromFile can be used.

[ViktorHofer]

Oh nice, the next breaking change. @ellahathaway will you take care of it or should I?

[ellahathaway]

Oh nice, the next breaking change. @ellahathaway will you take care of it or should I?

@ViktorHofer Ikr. I've got this one, but thanks for offering to help :)