Skip to content

Update Arcade SDK publishing #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 78 commits into from
Jan 30, 2020
Merged

Update Arcade SDK publishing #96

merged 78 commits into from
Jan 30, 2020

Conversation

adaggarwal
Copy link
Member

@adaggarwal adaggarwal commented Jan 3, 2020 •
edited
Loading

Fixes #1439

@adaggarwal adaggarwal requested review from dseefeld and crummel January 3, 2020 20:51
@adaggarwal adaggarwal self-assigned this Jan 3, 2020
JohnTortugo
JohnTortugo reviewed Jan 27, 2020
View reviewed changes
@adaggarwal
Copy link
Member Author

The newer version(.NET 5) of these scripts don't show the warning, but that's not ported to .net 3. So this build would continue to show them until we get subscribed to .NET 5.

dagood
dagood approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Just a couple of tiny suggestions.

adaggarwal and others added 2 commits January 29, 2020 11:18
@adaggarwal @dagood
azure-pipeline: remove pushd
4a068e6 
Co-Authored-By: Davis Goodin <dagood@users.noreply.github.com>
@adaggarwal @dagood
xml style update
edffa06 
Co-Authored-By: Davis Goodin <dagood@users.noreply.github.com>
@adaggarwal
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

riarenas
riarenas reviewed Jan 29, 2020
View reviewed changes
riarenas
riarenas reviewed Jan 29, 2020
View reviewed changes
src/publishPackages/publish.proj Outdated
<NewManifestBuildData Include="AzureDevOpsBuildDefinitionId=$(SYSTEM_DEFINITIONID)" />
<NewManifestBuildData Include="AzureDevOpsAccount=$(AzureDevOpsAccount)" />
<NewManifestBuildData Include="AzureDevOpsProject=$(SYSTEM_TEAMPROJECT)" />
<NewManifestBuildData Include="AzureDevOpsBuildNumber=$(ManifestBuildId)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be $(BUILD_BUILDNUMBER), this should report a value such as 20200129.2 but right now it's reporting the same thing as AzureDevOpsBuildId

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks.

riarenas
riarenas approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@riarenas riarenas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the AzureDevOpsBuildNumber in the manifest is correct.

@adaggarwal adaggarwal mentioned this pull request Jan 29, 2020
Closed
@adaggarwal adaggarwal merged commit c1dca16 into dotnet:master Jan 30, 2020
@adaggarwal adaggarwal mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTortugo JohnTortugo JohnTortugo approved these changes

@dseefeld dseefeld dseefeld approved these changes

@crummel crummel crummel approved these changes

@dagood dagood dagood approved these changes

@riarenas riarenas riarenas approved these changes

Assignees

@adaggarwal adaggarwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[source-build-reference-packages] Use new Arcade SDK publishing infrastructure
6 participants
@adaggarwal @JohnTortugo @dseefeld @crummel @dagood @riarenas