Skip to content

[main] Add maintenance-packages entries #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Mar 20, 2025

Same as #1203 but for main and without Build.props.

These packages include the recent fixes from today.

Note that System.Runtime.CompilerServices.Unsafe is not in this PR compared to the 9.0, because that one did not get a new version (and we had merged it previously already).

cc @ViktorHofer @ericstj @MichaelSimons

@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 20, 2025

I think SBRP needs a fix first. It's not respecting placeholder files and dropping TFMs for it.

@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 20, 2025

/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.25164.6/tools/SourceBuild/AfterSourceBuild.proj(83,5): error : 7 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.

@MichaelSimons this error is fun. The 7 listed packages that are getting added via this PR are reported as prebuilts :D

@MichaelSimons
Copy link
Member

@MichaelSimons this error is fun. The 7 listed packages that are getting added via this PR are reported as prebuilts :D

That's because you can't port the source between branches now that main vs servicing define the project references differently (project vs package reference). It is fortunate that the build order happened to catch this because it is not guaranteed. I am going to call this out in the readme.

@MichaelSimons
Copy link
Member

I regenerated the packages and verified in a local build.

@carlossanlop
Copy link
Contributor Author

Thanks for regenerating the packages. Good to know I shouldn't backport.

@MichaelSimons MichaelSimons merged commit cf30e8f into dotnet:main Mar 20, 2025
4 checks passed
@MichaelSimons
Copy link
Member

@carlossanlop - Can you tell me if all of the dependency work on this PR been submitted? I ask because I am in the process of removing all SBRP that are detected as being unreferenced in the product source build. Two of the packages added here are detected as unreferenced. I am wondering if that is true or if they are undetected because the dependency work hasn't flown into the VMR yet.

/src/referencePackages/src/system.net.websockets.websocketprotocol/5.1.2
src/referencePackages/src/system.reflection.dispatchproxy/4.8.2

@carlossanlop carlossanlop deleted the AddMaintenancePackagesPrebuilsMainAgain branch April 2, 2025 17:22
@carlossanlop
Copy link
Contributor Author

@carlossanlop - Can you tell me if all of the dependency work on this PR been submitted? I ask because I am in the process of removing all SBRP that are detected as being unreferenced in the product source build. Two of the packages added here are detected as unreferenced. I am wondering if that is true or if they are undetected because the dependency work hasn't flown into the VMR yet.

Hey, I was out the last couple of days.

I don't think we haven't flowed everything to the VMR, there were various deps flow conflicts and we're still going through them. Let's come back to this in a couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants