Add Customizations.props and change extension point #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import Customizations.props after the project file so that it can modify the project content via property or item operations.
mthalman
approved these changes
Mar 3, 2025
|
|
||
| <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'"> | ||
| <!-- Necessary for PermissionSet types but as a dangling compile-time only reference. --> | ||
| <ProjectReference Include="../../system.security.permissions/7.0.0/System.Security.Permissions.7.0.0.csproj" PrivateAssets="all" /> |
There was a problem hiding this comment.
Why was this defined as a project reference vs a package reference?
There was a problem hiding this comment.
Oh, that's coming from my other PR and was a copy paste error.
There was a problem hiding this comment.
I figured so, no action needed unless that work for whatever reason isn't completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1185
Import Customizations.props after the project file so that it can modify the project content via property or item operations.
Add Customizations.props files for 4 projects
With this, only nuspec and csharp files now show unrelated changes when re-generating all packages.