Skip to content

Add version 4.8.1 of System.Reflection.DispatchProxy and 6.1.1 of System.Runtime.CompilerServices.Unsafe #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 19, 2025
Merged

Add version 4.8.1 of System.Reflection.DispatchProxy and 6.1.1 of System.Runtime.CompilerServices.Unsafe #1151

merged 6 commits into from
Feb 19, 2025

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Feb 4, 2025 •
edited
Loading

This PR is result of testing the parallel dependency updates to ensure source-build does not break: dotnet/dotnet#133

System.ValueTuple did not generate anything when running generate.sh against it:

./generate.sh --package System.ValueTuple,4.6.0
Restore complete (0.5s)
  PackageSourceGeneratorTask succeeded (3.1s) → artifacts/bin/PackageSourceGeneratorTask/Debug/net10.0/PackageSourceGeneratorTask.dll
  PackageSourceGenerator succeeded (0.2s) → Package source generation skipped for System.ValueTuple (v4.6.0) as it doesn't contain any compile items.

Build succeeded in 4.7s

IMPORTANT: I need to merge this PR at the same time as all the other PRs in the other repos, to prevent breaking the dependency ingestion in the dotnet/sdk repo.

@MichaelSimons Please remind me if we need to include the feed or not.

@MichaelSimons
Copy link
Member

MichaelSimons commented Feb 4, 2025 •
edited
Loading

@MichaelSimons Please remind me if we need to include the feed or not.

Yes because we need the ability to generate the checked in packages overtime.

MichaelSimons
MichaelSimons reviewed Feb 4, 2025
View reviewed changes
NuGet.config Outdated
@@ -5,6 +5,7 @@
</fallbackPackageFolders>
<packageSources>
<clear />
<add key="darc-pub-dotnet-maintenance-packages-f9ed1720" value="https://dnceng.pkgs.visualstudio.com/public/_packaging/darc-pub-dotnet-maintenance-packages-f9ed1720/nuget/v3/index.json" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved to the other darc feed. It would be helpful to add a comment like the other feed as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, can you elaborate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my wording was poor. Please move it next to the other existing darc feed - https://github.com/dotnet/source-build-reference-packages/blob/main/NuGet.config#L24

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Sure, will do.

...em.runtime.compilerservices.unsafe/6.1.1/System.Runtime.CompilerServices.Unsafe.6.1.1.csproj
@@ -0,0 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project will need to be added to https://github.com/dotnet/source-build-reference-packages/blob/main/eng/Build.props#L45 per the instructions

Add DependencyPackageProjects for all new projects in the [eng/Build.props](https://github.com/dotnet/source-build-reference-packages/blob/main/eng/Build.props#L9) in the correct dependency order.

@MichaelSimons
Copy link
Member

System.ValueTuple did not generate anything when running generate.sh against it:

I take it the package isn't referenced in the SB graph given your VMR validation was green.

@carlossanlop
Add DependencyPackageProjects entry in eng/Build.props.
017f795 
Move nuget.config key to the bottom with a comment.
@carlossanlop carlossanlop marked this pull request as ready for review February 5, 2025 18:09
@carlossanlop carlossanlop requested a review from a team as a code owner February 5, 2025 18:09
@carlossanlop
Copy link
Contributor Author

carlossanlop commented Feb 5, 2025 •
edited
Loading

Should we merge this before all the other PRs? I think this one would not break the sdk deps flow if we merge it first.

Edit: Need some clarification from my team offline. Making it draft for now.

@carlossanlop carlossanlop marked this pull request as draft February 5, 2025 18:28
@MichaelSimons
Copy link
Member

Should we merge this before all the other PRs? I think this one would not break the sdk deps flow if we merge it first.

Edit: Need some clarification from my team offline. Making it draft for now.

Correct, This is additive so it can be merged ahead of the incoming changes.

@MichaelSimons
Copy link
Member

Once you mark it as ready for review, I will go ahead and merge it.

@carlossanlop carlossanlop marked this pull request as ready for review February 12, 2025 23:44
@carlossanlop
Copy link
Contributor Author

Once you mark it as ready for review, I will go ahead and merge it.

Oops, fixed. Thanks!

@carlossanlop carlossanlop marked this pull request as draft February 12, 2025 23:46
@carlossanlop
Copy link
Contributor Author

Wait, let me update the feed. I had to generate a new version for a new package.

@carlossanlop carlossanlop marked this pull request as ready for review February 18, 2025 22:10
@carlossanlop carlossanlop marked this pull request as draft February 18, 2025 22:11
@carlossanlop carlossanlop marked this pull request as ready for review February 18, 2025 22:23
@carlossanlop
Copy link
Contributor Author

Okay! Ready. I updated the feed to the latest, then I added System.Runtime.CompilerServices and also added the recently updated System.Reflection.DispatchProxy to the repo and updated build.props. As previously mentioned, System.ValueTuple is not getting added by generate.sh.

@carlossanlop carlossanlop changed the title Add version 6.1.1 of System.ValueTuple and System.Runtime.CompilerServices.Unsafe Add version 6.1.1 of System.Reflection.DispatchProxy and System.Runtime.CompilerServices.Unsafe Feb 18, 2025
@carlossanlop carlossanlop changed the title Add version 6.1.1 of System.Reflection.DispatchProxy and System.Runtime.CompilerServices.Unsafe Add version 4.8.1 of System.Reflection.DispatchProxy and 6.1.1 of System.Runtime.CompilerServices.Unsafe Feb 18, 2025
@MichaelSimons MichaelSimons merged commit d794781 into dotnet:main Feb 19, 2025
4 checks passed
@carlossanlop carlossanlop mentioned this pull request Mar 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlossanlop @MichaelSimons