Skip to content

Add back some recently removed packages #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

MichaelSimons
Copy link
Member

Adding back the following packages:

referencePackages/src/system.formats.asn1/8.0.0
referencePackages/src/system.security.cryptography.pkcs/8.0.0
referencePackages/src/system.security.cryptography.xml/8.0.0
referencePackages/src/system.text.json/8.0.4

These packages were removed in #1108 but #1110 and #1109 which were merged after added dependencies on them. It was not caught in validation because the packages existed in the n-1 self-reference. This would be solved by dotnet/source-build#1690.

@ellahathaway
Copy link
Member

Orthogonal to the changes in this PR - it's unfortunate that we have to reintroduce referencePackages/src/system.formats.asn1/8.0.0 due to its CVE, which is causing CG alerts in SBRP: dotnet/source-build#4751.

I understand it's necessary in this case, but I wonder if we could have implemented something in PR validation to detect that the packages referencing this dependency are dependent on a package with a CVE.

@NikolaMilosavljevic
Copy link
Member

Are DependencyPackageProjects entries in eng/Build.props also needed?

@MichaelSimons
Copy link
Member Author

Are DependencyPackageProjects entries in eng/Build.props also needed?

No because the packages are already in the n-1 artifacts.

@MichaelSimons MichaelSimons merged commit 1d0bf11 into dotnet:main Jan 10, 2025
4 checks passed
@MichaelSimons MichaelSimons deleted the re-add branch January 10, 2025 17:52
@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 10, 2025

Orthogonal to the changes in this PR - it's unfortunate that we have to reintroduce referencePackages/src/system.formats.asn1/8.0.0

System.Security.Cryptography.Pkcs/8.0.0 is the only package that references System.Formats.Asn/8.0.0. Should we patch SSCP to reference the 8.0.1 version of SFAsn1 instead?

@MichaelSimons
Copy link
Member Author

System.Security.Cryptography.Pkcs/8.0.0 is the only package that references System.Formats.Asn/8.0.0. Should we patch SSCP to reference the 8.0.1 version of SFAsn1 instead?

Yes that is the way to address the CG. That work will be done as part of dotnet/source-build#4751.

@ViktorHofer
Copy link
Member

I should have done that in my original PR but missed it - sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants