Remove unused spectre-console #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaMilosavljevic
approved these changes
Apr 2, 2025
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/source-build-externals/actions/runs/14309305607 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spectre-console is currently not being referenced by any product code. Per a discussion with @baronfel, after this SBE was added, the msbuild/sdk teams got pulled in a different direction and haven't got back to the work to make use of the library. There is no timeline on when this work will happen. Given this, we agreed to remove the spectre-console library from the source-build-externals repo given it is "dead" code and there is a cost associated with it e.g. build time and compliance overhead. When this work is picked back up, this code can be added back in. This PR should get backported to 9.0 as well.