Skip to content

Add System.ComponentModel.Composition#672

Merged
MichaelSimons merged 2 commits into
dotnet:mainfrom
Evangelink:composition
May 16, 2023
Merged

Add System.ComponentModel.Composition#672
MichaelSimons merged 2 commits into
dotnet:mainfrom
Evangelink:composition

Conversation

@Evangelink

Copy link
Copy Markdown
Member

No description provided.

@MichaelSimons

Copy link
Copy Markdown
Member

For traceability, this reference pack is required by vstest. See microsoft/vstest#4456.

Comment thread eng/Build.props
<DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\Microsoft.CodeAnalysis.VisualBasic.Workspaces.4.5.0.csproj" />
<DependencyPackageProjects Include="$(RepoRoot)src\textOnlyPackages\src\**\Microsoft.CodeAnalysis.4.5.0.csproj" />

<DependencyPackageProjects Include="$(RepoRoot)src\textOnlyPackages\src\**\System.ComponentModel.Composition.7.0.0.csproj" />

@MichaelSimons MichaelSimons May 16, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Evangelink - Apologies, I noticed the step to add this was missing from the Workflow instructions I pointed you too so I added it for you.
I opened a PR to address the workflow.

@MichaelSimons MichaelSimons enabled auto-merge (squash) May 16, 2023 14:40
@MichaelSimons MichaelSimons merged commit f2455b4 into dotnet:main May 16, 2023
@Evangelink Evangelink deleted the composition branch May 16, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants