-
Notifications
You must be signed in to change notification settings - Fork 48
Issue 38: Update to use Microsoft.Extensions.AI.Abstractions library #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
quattro004
wants to merge
11
commits into
dotnet:main
Choose a base branch
from
quattro004:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…previous backend vs the update to use the Microsoft extensions AI libraries. Most tests are passing now.
… the repo shared config.
…epo shared config. See AddRepoSharedConfig
… dummy API key value if the configuration value isn't found so that the app will start up and not error out.
…responses, had removed too much code during the refactor to use Microsoft.Extensions.AI.
@microsoft-github-policy-service agree |
@microsoft-github-policy-service rerun |
…ly. Had the wrong data in the response cache file that the tests were using.
@dotnet-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the codebase to use the Microsoft.Extensions.AI.Abstractions library. I also noticed that since we are removing the SmartComponents.Inference.OpenAI project completely we might need a follow up task to update this documentation which mentions the project https://github.com/dotnet/smartcomponents/blob/main/docs/configure-openai-backend.md. Should I create this issue? Finally, I had some trouble getting all of the e2e tests to work, there's 10 that are failing and seem to be related to the same problem. I am having a hard time debugging them as it seems to change the state if it takes me too long in the debugger even in the existing test suite. Anyway, since I'm stuck on that I figured I would get this PR out there for review and we can proceed from there. Thanks for the opportunity to contribute.