Skip to content

fix(devops-health): resilient dashboard issue discovery - #737

Merged
JanKrivanek merged 2 commits into
mainfrom
fix/devops-health-dashboard-discovery
Jun 9, 2026
Merged

JanKrivanek merged 2 commits into
mainfrom
fix/devops-health-dashboard-discovery

Conversation

@JanKrivanek

Copy link
Copy Markdown
Member

The health check found its dashboard issue only via the devops-health label search. When GitHub silently dropped the pinned dashboard (#288) from its search/list index, the workflow couldn't find it, created a duplicate (#695), and abandoned the pinned issue — leaving it stale for days.

Step 4.1 now resolves the dashboard by a cached issue number first (updating it directly by number, which works even when the issue is missing from search), persists that number every run, falls back to label + pinned-issue lookup, and consolidates duplicates.

Lock file unchanged — the prompt is runtime-imported from these .md files.

Live cleanup already applied: #695 pinned, #288 closed as duplicate.

The health check located its dashboard issue solely via the devops-health label search. When GitHub silently dropped the pinned dashboard (#288) from its issue search/list index, the workflow could not find it, created a duplicate (#695), and abandoned the pinned issue -- leaving the pinned dashboard stale for days.

Step 4.1 now resolves the dashboard by a cached issue number first (updating it directly by number, which works even when the issue is missing from search), persists that number to cache-memory every run, falls back to label + pinned-issue lookup, and consolidates duplicates. Documents the new health-dashboard-issue cache key.

Lock file unchanged: the prompt body is runtime-imported from these .md files.
@JanKrivanek
JanKrivanek marked this pull request as ready for review June 9, 2026 15:26
Copilot AI review requested due to automatic review settings June 9, 2026 15:26
@JanKrivanek
JanKrivanek requested a review from dbreshears as a code owner June 9, 2026 15:26
@JanKrivanek
JanKrivanek enabled auto-merge (squash) June 9, 2026 15:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the DevOps Health Check workflow’s stability by ensuring it consistently finds and updates the same “Repository Health Dashboard” issue even when GitHub search/label indexing fails, preventing duplicate dashboard creation.

Changes:

  • Updates Step 4.1 in the workflow prompt to resolve the dashboard issue by cached issue number first, then fall back to label/pinned discovery, and consolidate duplicates.
  • Adds health-dashboard-issue as a documented cache-memory key to persist the canonical dashboard issue number across runs.
  • Adds an explicit verification checklist item to avoid duplicating the dashboard due to empty label search results.
Show a summary per file
File Description
.github/workflows/devops-health-check.md Updates the workflow prompt to resolve/update the dashboard issue reliably (cached number first) and adds guidance to prevent duplicates.
.github/aw/shared/devops-health.lock.md Documents the new cache-memory key used to persist the canonical dashboard issue number.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 2

Comment thread .github/workflows/devops-health-check.md Outdated
Comment thread .github/workflows/devops-health-check.md Outdated
@github-actions github-actions Bot added the waiting-on-author PR state label label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

👋 @JanKrivanek — this PR has 2 unresolved review thread(s). When you're ready, please address the feedback and push an update; the triage bot will pick up the next state automatically. (Add the no-stale label to silence further pings.)

…uest

Address PR review feedback:

- Validate the cached health-dashboard-issue before reusing it (open + devops-health label or expected title); treat 404/mismatch as a cache miss so the label/pinned fallback recovers safely instead of overwriting an unrelated issue.

- Move the 'please pin' request inside the body template (below the status block) instead of above the required header, so it no longer conflicts with the documented body format or island replacement.
@JanKrivanek
JanKrivanek merged commit 7bd6628 into main Jun 9, 2026
35 checks passed
@JanKrivanek
JanKrivanek deleted the fix/devops-health-dashboard-discovery branch June 9, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-author PR state label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants