Skip to content

Fix flaky test #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dtivel merged 1 commit into from
Feb 27, 2026
Merged

Fix flaky test #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions test/Sign.Core.Test/TestInfrastructure/Server/CertificatesFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ internal X509Certificate TimestampServiceCertificate
get => _timestampService.Certificate;
}

internal DirectoryInfo TimestampServiceLogDirectory
{
get => _timestampService.LogDirectory;
}

public CertificatesFixture()
{
TestUtility.RemoveTestIntermediateCertificates();
Expand Down
5 changes: 0 additions & 5 deletions test/Sign.Core.Test/TestInfrastructure/Server/TimestampService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,6 @@ internal sealed class TimestampService : HttpResponder, IDisposable
/// </summary>
internal CertificateAuthority CertificateAuthority { get; }

internal DirectoryInfo LogDirectory
{
get => _temporaryDirectory.Directory;
}

private TimestampService(
CertificateAuthority certificateAuthority,
X509Certificate2 certificate,
Expand Down
16 changes: 0 additions & 16 deletions test/Sign.Core.Test/Tools/VSIXSignTool/Crypt32Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ public void ShouldTimestampData()
// Capture the last P/Invoke error and throw later.
Win32Exception exception = new();

LogTimestampDetails();

if (!ok)
{
throw exception;
Expand All @@ -63,19 +61,5 @@ public void ShouldTimestampData()
}
}
}

private void LogTimestampDetails()
{
FileInfo? file = _certificatesFixture.TimestampServiceLogDirectory.GetFiles()
.OrderByDescending(file => file.Name)
.FirstOrDefault();

if (file is not null)
{
string content = File.ReadAllText(file.FullName);

_testOutputHelper.WriteLine(content);
}
}
}
}
25 changes: 1 addition & 24 deletions test/Sign.Core.Test/Tools/VSIXSignTool/OpcPackageSigningTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,36 +89,13 @@ public async Task ShouldTimestampFileWithRsa(int keySizeInBits, HashAlgorithmNam
fileDigestAlgorithm: HashAlgorithmName.SHA256,
signingKey: rsaPrivateKey!));
OpcPackageTimestampBuilder timestampBuilder = signature.CreateTimestampBuilder();
TimestampResult result;

try
{
result = await timestampBuilder.SignAsync(_certificatesFixture.TimestampServiceUrl, timestampDigestAlgorithm);
}
finally
{
LogTimestampDetails();
}
TimestampResult result = await timestampBuilder.SignAsync(_certificatesFixture.TimestampServiceUrl, timestampDigestAlgorithm);

Assert.Equal(TimestampResult.Success, result);
}
}
}

private void LogTimestampDetails()
{
FileInfo? file = _certificatesFixture.TimestampServiceLogDirectory.GetFiles()
.OrderByDescending(file => file.Name)
.FirstOrDefault();

if (file is not null)
{
string content = File.ReadAllText(file.FullName);

_testOutputHelper.WriteLine(content);
}
}

[Fact]
public void ShouldSupportReSigning()
{
Expand Down