Skip to content

Pass in RSA instead of X509Certificate2 in the constructor of the RSATrustedSigning class. #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dtivel merged 1 commit into from
May 12, 2025
Merged

Pass in RSA instead of X509Certificate2 in the constructor of the RSATrustedSigning class. #870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Sign.SignatureProviders.TrustedSigning/RSATrustedSigning.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// See the LICENSE.txt file in the project root for more information.

using System.Security.Cryptography;
using System.Security.Cryptography.X509Certificates;
using Azure;
using Azure.CodeSigning;
using Azure.CodeSigning.Models;
Expand All @@ -21,12 +20,12 @@ public RSATrustedSigning(
CertificateProfileClient client,
string accountName,
string certificateProfileName,
X509Certificate2 certificate)
RSA rsaPublicKey)
{
_client = client;
_accountName = accountName;
_certificateProfileName = certificateProfileName;
_rsaPublicKey = certificate.GetRSAPublicKey()!;
_rsaPublicKey = rsaPublicKey;
}

protected override void Dispose(bool disposing)
Expand Down
3 changes: 2 additions & 1 deletion src/Sign.SignatureProviders.TrustedSigning/TrustedSigningService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ public async Task<X509Certificate2> GetCertificateAsync(CancellationToken cancel
public async Task<RSA> GetRsaAsync(CancellationToken cancellationToken)
{
using X509Certificate2 certificate = await GetCertificateAsync(cancellationToken);
return new RSATrustedSigning(_client, _accountName, _certificateProfileName, certificate);
RSA rsaPublicKey = certificate.GetRSAPublicKey()!;
return new RSATrustedSigning(_client, _accountName, _certificateProfileName, rsaPublicKey);
}
}
}