-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure Key Vault version support #789
base: main
Are you sure you want to change the base?
Conversation
@jimmycartrette please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimmycartrette, thank you for your contribution!
Overall, the PR looks very good. Thanks for adding tests. I left only minor feedback. Mention me when ready, and I'll merge.
test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProviderTests.cs
Outdated
Show resolved
Hide resolved
test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProviderTests.cs
Outdated
Show resolved
Hide resolved
test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProviderTests.cs
Outdated
Show resolved
Hide resolved
test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceTests.cs
Outdated
Show resolved
Hide resolved
test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProviderTests.cs
Outdated
Show resolved
Hide resolved
test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProviderTests.cs
Outdated
Show resolved
Hide resolved
Thanks, @jimmycartrette! It's looking good. Thanks for making those changes. Only a few things remain:
|
…me. Add test case to ensure addition or removal of option does not affect tests
Co-authored-by: Damon Tivel <dtivel@microsoft.com>
Co-authored-by: Damon Tivel <dtivel@microsoft.com>
Co-authored-by: Damon Tivel <dtivel@microsoft.com>
Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…iderTests.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…iderTests.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…iderTests.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…s.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…iderTests.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…iderTests.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…iderTests.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…iderTests.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…iderTests.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…iderTests.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…iderTests.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…s.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…s.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…s.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…s.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…s.cs Co-authored-by: Damon Tivel <dtivel@microsoft.com>
a9dcc5d
to
6480eaf
Compare
Thanks I'm just trying to get confirmation that I can sign the agreement |
Adding Azure Key Vault certificate version support, similar to azuresigntool changes.