-
Notifications
You must be signed in to change notification settings - Fork 110
"trusted-signing <file(s)>" doesn't accept multiple files #815
Copy link
Copy link
Closed
Labels
Priority:2Work that is important, but not critical for the releaseWork that is important, but not critical for the releasecommunity-contributionIndicates that the PR has been added by a community memberIndicates that the PR has been added by a community membertool-parityWork necessary to bring Sign CLI up to feature parity with an existing toolWork necessary to bring Sign CLI up to feature parity with an existing tool
Metadata
Metadata
Assignees
Labels
Priority:2Work that is important, but not critical for the releaseWork that is important, but not critical for the releasecommunity-contributionIndicates that the PR has been added by a community memberIndicates that the PR has been added by a community membertool-parityWork necessary to bring Sign CLI up to feature parity with an existing toolWork necessary to bring Sign CLI up to feature parity with an existing tool
Type
Fields
Give feedbackNo fields configured for issues without a type.
Describe the bug
Run
sign code trusted-signing --help. It prints:The expectation is that one can pass multiple absolute paths (to different DLLs or EXEs) to the command. However, if you do so, you get the error:
Repro steps
Run:
You get the error:
Expected behavior
Multiple files can be specified and all will be signed.
Actual behavior
The second file generates an error.
Additional context
sign --version: 0.9.1-beta.24529.1+029731ca2df9d41933a09a1cc9212595a7c7932adotnet --info.Appears to be related to this:
sign/src/Sign.Cli/TrustedSigningCommand.cs
Line 21 in 4dcffd3
The simplest fix would be to change the documentation to
<file>, not<file(s)>. However, the desired behavior would be for multiple files to be supported.I was going to try using a file list as a workaround but I saw #768 which indicates that that might not work.