Keep MSTest.Sdk in sync with MSTest framework to fix NativeAOT test discovery by dsplaisted · Pull Request #55302 · dotnet/sdk

dsplaisted · 2026-07-15T18:55:27Z

We had mismatched versions of the MSTest.Sdk and the MSTest package references. Apparently this no longer works when using NativeAOT tests. So this adds a declared dependency to MSTest.Sdk so the reference in global.json will get updated in sync.

EDIT: Also updated to temporarily disable win-arm64 NativeAOT (AoT) CI leg. This was added in #55205 but has never passed, and is failing with errors like

dotnet-aot.obj : fatal error LNK1322: cannot avoid potential ARM hazard
   (Cortex-A53 MPCore processor bug #843419) in section 0x2; consider compiler option /Gy
error MSB3073: ...Hostx64\arm64\link.exe ... exited with code 1322

Verbose Copilot description

The test/dotnet-aot.Tests project publishes as NativeAOT and relies on the MSTest source generator for test discovery (reflection-based discovery isn't AOT-safe). That requires two versions to stay coherent:

MSTest.Sdk — the MSBuild SDK, pinned in global.json (msbuild-sdks), which provides the NativeAOT discovery targets + source generator.
MSTestPackageVersion (the MSTest framework/runtime packages) — flowed by darc from microsoft/testfx.

A dotnet/dotnet flow bumped MSTestPackageVersion 4.3.0-preview.26355.11 → 4.4.0-preview.26360.5, but MSTest.Sdk stayed pinned at 4.3.0-preview.26325.12 in global.json. Shortly after, #54719 enabled the Run NativeAOT CLI Tests leg for the first time.

With the SDK (4.3.0) and framework (4.4.0) skewed, the MSTest source generator registers zero tests, so the AOT binary reports Test run summary: Zero tests ran and exits with MTP code 8 — failing the leg on every main build. (Normal reflection-based MSTest runs tolerate the skew, so only the AOT leg breaks.)

#54719 itself was green because it was validated while MSTest was still coherent at 4.3.0; it merged into a main that had already moved the framework to 4.4.0.

Fix

global.json — bump MSTest.Sdk to 4.4.0-preview.26360.5 (same microsoft/testfx build as the MSTest framework packages), re-cohering the source generator with the runtime.
eng/Version.Details.xml — track MSTest.Sdk as a darc dependency from microsoft/testfx, next to MSTest.

Why this keeps them in sync going forward

Microsoft.DotNet.Arcade.Sdk and Microsoft.DotNet.Helix.Sdk already live in both global.json msbuild-sdks and eng/Version.Details.xml, so darc keeps their global.json versions updated in lockstep with the flow. MSTest.Sdk was the odd one out — global.json only, hand-bumped, free to drift. Tracking it in Version.Details.xml makes darc update MSTest.Sdk in global.json together with the MSTest framework packages on every testfx flow. Since testfx publishes both at the same build/version string, they can no longer drift apart.

Verification

darc get-dependencies parses the new MSTest.Sdk dependency.
global.json is valid JSON; eng/Version.Details.xml is well-formed.
MSTest.Sdk 4.4.0-preview.26360.5 is present on the dotnet-tools / test-tools feeds and matches MSTest 4.4.0-preview.26360.5 (build f19af28).

Fixes the Run NativeAOT CLI Tests failures introduced alongside #54719.

…iscovery The test/dotnet-aot.Tests project publishes as NativeAOT and relies on the MSTest source generator for test discovery (reflection isn't AOT-safe). That requires MSTest.Sdk (the MSBuild SDK pinned in global.json) and the MSTest framework packages (MSTestPackageVersion, flowed by darc from microsoft/testfx) to be coherent. A dotnet/dotnet flow bumped MSTestPackageVersion to 4.4.0-preview.26360.5 while MSTest.Sdk stayed at 4.3.0-preview.26325.12, and PR dotnet#54719 then enabled the NativeAOT CLI test leg. The SDK/framework skew makes the source generator register zero tests, so the leg fails with MTP exit code 8 (Test run summary: Zero tests ran) on every main build. Normal reflection-based MSTest runs tolerate the skew, so only the AOT leg breaks. Fix: bump MSTest.Sdk to 4.4.0-preview.26360.5 (same testfx build as the MSTest framework), and track MSTest.Sdk as a darc dependency in eng/Version.Details.xml. Like Microsoft.DotNet.Arcade.Sdk and .Helix.Sdk, darc then updates its global.json msbuild-sdks version in lockstep with the MSTest framework packages, preventing the versions from drifting apart again. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 59570d89-a7e3-4993-baa9-3fb1f442a617

azure-pipelines · 2026-07-15T18:55:41Z

Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Pull request overview

Updates the pinned MSTest.Sdk MSBuild SDK version and starts tracking it as a darc-managed dependency so it stays aligned with the MSTest framework packages—fixing NativeAOT MSTest discovery where version skew can lead to zero discovered tests.

Changes:

Bump MSTest.Sdk in global.json msbuild-sdks to 4.4.0-preview.26360.5.
Add MSTest.Sdk as a dependency in eng/Version.Details.xml (from microsoft/testfx) so darc can keep the global.json pin in sync with MSTest.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
global.json	Updates the pinned `MSTest.Sdk` MSBuild SDK version used by the repo.
eng/Version.Details.xml	Adds `MSTest.Sdk` as a tracked dependency so darc updates it alongside MSTest/TestFX flows.

baronfel · 2026-07-15T18:56:53Z

Nice! I have a crappier version of this over in my PR but yours fixes the root cause of the out-of-sync.

…um 843419) The 'AoT: windows (arm64)' cross-build leg added in dotnet#55205 has never passed: the win-arm64 NativeAOT cross-link fails with 'LNK1322: cannot avoid potential ARM hazard (Cortex-A53 MPCore processor bug #843419)' because the ILCompiler-produced object is not split into per-function sections, so the MSVC arm64 linker cannot apply the erratum fixup. Only win-arm64 is affected (win-x64, osx-arm64, linux-x64/arm64 AoT legs all pass). Set disableJob: true on the win-arm64 AoT job parameter set in .vsts-pr.yml and .vsts-ci.yml to stop it red-walling every build until the underlying ILCompiler fix lands. Re-enable by removing disableJob. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 59570d89-a7e3-4993-baa9-3fb1f442a617

Bumps the microsoft/testfx dependency group to the latest coherent build (4.4.0-preview.26366.2 / MTP 2.4.0-preview.26366.2, testfx c1e6453) across all three places that must agree: - global.json msbuild-sdks -> MSTest.Sdk (the source generator) - eng/Version.Details.props -> MSTestPackageVersion + MicrosoftTestingPlatformPackageVersion - eng/Version.Details.xml -> MSTest, MSTest.Sdk, Microsoft.Testing.Platform (+ Sha) The MSTest.Sdk source generator emits test registrations against the MSTest.TestFramework runtime, so these must come from the same testfx build. A skew breaks the NativeAOT CLI test build ("Zero tests ran" when the generator lags, CS0234 on DynamicDataSourceResolver when it leads). Adds KEEP-IN-SYNC comments over each version so future manual edits keep them together. See dotnet#55302. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1b315003-e0fc-4a09-865e-c8f4750fe3a5

Copilot AI review requested due to automatic review settings July 15, 2026 18:55

Copilot started reviewing on behalf of dsplaisted July 15, 2026 18:55 View session

baronfel approved these changes Jul 15, 2026

View reviewed changes

Copilot AI reviewed Jul 15, 2026

View reviewed changes

baronfel mentioned this pull request Jul 15, 2026

Adopt MSBuild partial ProjectInstance evaluation in CLI hot paths #55271

Merged

baronfel enabled auto-merge (squash) July 15, 2026 19:02

baronfel disabled auto-merge July 15, 2026 19:02

baronfel mentioned this pull request Jul 15, 2026

Enable NativeAOT CLI command handling by default (DOTNET_CLI_ENABLEAOT) #55144

Merged

dsplaisted enabled auto-merge July 15, 2026 19:45

dsplaisted requested review from MiYanni and MichaelSimons as code owners July 15, 2026 20:54

baronfel approved these changes Jul 15, 2026

View reviewed changes

dsplaisted merged commit de83a9c into dotnet:main Jul 15, 2026
27 checks passed

dotnet-maestro Bot mentioned this pull request Jul 16, 2026

[main] Source code updates from dotnet/sdk dotnet/dotnet#7776

Merged

dotnet-milestone-bot Bot added this to the 11.0-preview7 milestone Jul 16, 2026

Evangelink mentioned this pull request Jul 16, 2026

Align MSTest/testfx package versions and document the sync requirement #55316

Merged

Navigation Menu

Uh oh!

Keep MSTest.Sdk in sync with MSTest framework to fix NativeAOT test discovery - #55302

Keep MSTest.Sdk in sync with MSTest framework to fix NativeAOT test discovery#55302
dsplaisted merged 2 commits into
dotnet:mainfrom
dsplaisted:dsplaisted/fix-mstest-sdk-sync

dsplaisted commented Jul 15, 2026 •

edited

Loading

Uh oh!

azure-pipelines Bot commented Jul 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

baronfel commented Jul 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

dsplaisted commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Verbose Copilot description

Fix

Why this keeps them in sync going forward

Verification

Uh oh!

azure-pipelines Bot commented Jul 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

baronfel commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dsplaisted commented Jul 15, 2026 •

edited

Loading

baronfel commented Jul 15, 2026 •

edited

Loading