Better error when workload set version uses package version format by Copilot · Pull Request #54929 · dotnet/sdk

Copilot · 2026-06-22T21:13:29Z

Users occasionally specify a workload set version in the internal NuGet package format (e.g. 10.105.0, 11.100.0-preview.5.26309.3) instead of the user-facing format (10.0.105, 11.0.100-preview.5). Previously this produced a confusing NuGet "package not found" failure; now workload operations and global.json produce a clear error with the corrected version.

The user-facing format always has 0 as the minor component — a non-zero minor is the diagnostic signal.

Changes

WorkloadSetVersion.cs — adds IsWorkloadSetVersionInPackageVersionFormat(string, out string?) which detects the wrong format and computes the corrected version string (8.203.1 → 8.0.203.1, 11.100.0-preview.5.26309.3 → 11.0.100-preview.5.26309.3)
WorkloadSetVersion.Validation.cs — deleted; was an orphaned file with conflicting duplicate definitions not compiled into any project
InstallingWorkloadCommand.cs — validates both --version command-line values and workloadVersion from global.json, throwing early with a helpful message
CliCommandStrings.resx — adds the new workload install / global.json error strings and updates the guidance text to describe the accepted minor-component rule without contradicting valid 4-part suggestions; XLF files regenerated
SdkFeatureBandTests.cs — adds coverage for detecting package-format workload set versions

Error messages

'10.103.0' is not a valid workload set version. The workload set version should have '0' as the minor component (for example, '10.0.105' or '10.0.103.1'). Did you mean '10.0.103'?

'11.100.0-preview.5.26309.3' is not a valid workload set version. The workload set version should have '0' as the minor component (for example, '10.0.105' or '10.0.103.1'). Did you mean '11.0.100-preview.5.26309.3'? (Specified in 'path/to/global.json')

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

…ment Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

marcpopMSFT · 2026-06-22T21:34:25Z

@copilot Fix the build errors

/mnt/vss/_work/1/s/src/Common/WorkloadSetVersion.cs(70,34): error CS0518: Predefined type 'System.Range' is not defined or imported [/mnt/vss/_work/1/s/src/Resolvers/Microsoft.DotNet.MSBuildSdkResolver/Microsoft.DotNet.MSBuildSdkResolver.csproj]
/mnt/vss/_work/1/s/src/Common/WorkloadSetVersion.cs(70,34): error CS0518: Predefined type 'System.Index' is not defined or imported [/mnt/vss/_work/1/s/src/Resolvers/Microsoft.DotNet.MSBuildSdkResolver/Microsoft.DotNet.MSBuildSdkResolver.csproj]
/mnt/vss/_work/1/s/test/Microsoft.DotNet.Cli.Utils.Tests/TransientSdkResolutionErrorDetectorTests.cs(8,10): error CS0246: The type or namespace name 'FactAttribute' could not be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/test/Microsoft.DotNet.Cli.Utils.Tests/Microsoft.DotNet.Cli.Utils.Tests.csproj]
/mnt/vss/_work/1/s/test/Microsoft.DotNet.Cli.Utils.Tests/TransientSdkResolutionErrorDetectorTests.cs(8,10): error CS0246: The type or namespace name 'Fact' could not be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/test/Microsoft.DotNet.Cli.Utils.Tests/Microsoft.DotNet.Cli.Utils.Tests.csproj]

…convert xUnit tests to MSTest Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

Copilot · 2026-06-22T21:42:49Z

@copilot Fix the build errors

/mnt/vss/_work/1/s/src/Common/WorkloadSetVersion.cs(70,34): error CS0518: Predefined type 'System.Range' is not defined or imported [/mnt/vss/_work/1/s/src/Resolver...

Fixed in the latest commit:

WorkloadSetVersion.cs — replaced the C# range indexer [sections[0].Length..] with Substring(sections[0].Length) for net472 compatibility (both System.Range and System.Index are unavailable on full framework). Verified the Microsoft.DotNet.MSBuildSdkResolver project now builds cleanly.
TransientSdkResolutionErrorDetectorTests.cs — converted from xUnit [Fact] to MSTest [TestClass]/[TestMethod] to match the project's MSTest.Sdk configuration. Verified the Microsoft.DotNet.Cli.Utils.Tests project now builds cleanly.

Copilot

Pull request overview

Improves the .NET SDK workload UX by detecting when users provide a workload set version in the internal NuGet package version format (e.g. 10.105.0) and emitting an early, actionable error message with a suggested corrected user-facing version (e.g. 10.0.105) instead of failing later with a confusing “package not found”.

Changes:

Added WorkloadSetVersion.IsWorkloadSetVersionInPackageVersionFormat(...) to detect the internal/package-style version format and compute a corrected suggestion.
Validated workload set version inputs in both the workload install path (CLI / global.json) and the workload search version command validator, using new localized error strings.
Added unit tests for the new detection logic and migrated an MSTest project test file from xUnit [Fact] to MSTest [TestMethod].

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/Microsoft.NET.Sdk.WorkloadManifestReader.Tests/SdkFeatureBandTests.cs	Adds coverage for detecting package-style workload set versions and verifying suggested corrected versions.
test/Microsoft.DotNet.Cli.Utils.Tests/TransientSdkResolutionErrorDetectorTests.cs	Converts xUnit attributes to MSTest attributes to match the project’s MSTest.Sdk usage.
src/Common/WorkloadSetVersion.Validation.cs	Removes an unused/orphaned duplicate validation file.
src/Common/WorkloadSetVersion.cs	Introduces the new detection + suggestion helper for package-version-formatted workload set versions.
src/Cli/Microsoft.DotNet.Cli.Definitions/Commands/Workload/WorkloadSearchVersionsCommandDefinition.cs	Updates argument validation to emit the specific “package format” error when detected.
src/Cli/Microsoft.DotNet.Cli.Definitions/CommandDefinitionStrings.resx	Adds a new localized string for the “workload set version in package format” error (definitions layer).
src/Cli/Microsoft.DotNet.Cli.Definitions/xlf/CommandDefinitionStrings.zh-Hant.xlf	Adds new trans-unit for the new error string.
src/Cli/Microsoft.DotNet.Cli.Definitions/xlf/CommandDefinitionStrings.zh-Hans.xlf	Adds new trans-unit for the new error string.
src/Cli/Microsoft.DotNet.Cli.Definitions/xlf/CommandDefinitionStrings.tr.xlf	Adds new trans-unit for the new error string.
src/Cli/Microsoft.DotNet.Cli.Definitions/xlf/CommandDefinitionStrings.ru.xlf	Adds new trans-unit for the new error string.
src/Cli/Microsoft.DotNet.Cli.Definitions/xlf/CommandDefinitionStrings.pt-BR.xlf	Adds new trans-unit for the new error string.
src/Cli/Microsoft.DotNet.Cli.Definitions/xlf/CommandDefinitionStrings.pl.xlf	Adds new trans-unit for the new error string.
src/Cli/Microsoft.DotNet.Cli.Definitions/xlf/CommandDefinitionStrings.ko.xlf	Adds new trans-unit for the new error string.
src/Cli/Microsoft.DotNet.Cli.Definitions/xlf/CommandDefinitionStrings.ja.xlf	Adds new trans-unit for the new error string.
src/Cli/Microsoft.DotNet.Cli.Definitions/xlf/CommandDefinitionStrings.it.xlf	Adds new trans-unit for the new error string.
src/Cli/Microsoft.DotNet.Cli.Definitions/xlf/CommandDefinitionStrings.fr.xlf	Adds new trans-unit for the new error string.
src/Cli/Microsoft.DotNet.Cli.Definitions/xlf/CommandDefinitionStrings.es.xlf	Adds new trans-unit for the new error string.
src/Cli/Microsoft.DotNet.Cli.Definitions/xlf/CommandDefinitionStrings.de.xlf	Adds new trans-unit for the new error string.
src/Cli/Microsoft.DotNet.Cli.Definitions/xlf/CommandDefinitionStrings.cs.xlf	Adds new trans-unit for the new error string.
src/Cli/dotnet/Commands/Workload/InstallingWorkloadCommand.cs	Adds early validation for command-line and `global.json` workload set versions, throwing a helpful error with a suggested corrected version.
src/Cli/dotnet/Commands/CliCommandStrings.resx	Adds new localized strings for the workload-set-version “package format” error (CLI layer), including a `global.json`-specific variant.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.zh-Hant.xlf	Adds new trans-units for the new CLI-layer error strings.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.zh-Hans.xlf	Adds new trans-units for the new CLI-layer error strings.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.tr.xlf	Adds new trans-units for the new CLI-layer error strings.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.ru.xlf	Adds new trans-units for the new CLI-layer error strings.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.pt-BR.xlf	Adds new trans-units for the new CLI-layer error strings.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.pl.xlf	Adds new trans-units for the new CLI-layer error strings.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.ko.xlf	Adds new trans-units for the new CLI-layer error strings.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.ja.xlf	Adds new trans-units for the new CLI-layer error strings.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.it.xlf	Adds new trans-units for the new CLI-layer error strings.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.fr.xlf	Adds new trans-units for the new CLI-layer error strings.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.es.xlf	Adds new trans-units for the new CLI-layer error strings.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.de.xlf	Adds new trans-units for the new CLI-layer error strings.
src/Cli/dotnet/Commands/xlf/CliCommandStrings.cs.xlf	Adds new trans-units for the new CLI-layer error strings.

Comments suppressed due to low confidence (1)

src/Cli/dotnet/Commands/CliCommandStrings.resx:2725

Same issue as the non-global.json variant: the message states 'major.0.patch' but corrected workload set versions may include an additional numeric component (major.0.sdkPatch.workloadSetPatch). Consider adjusting the described format so it matches the suggestion output.

</root>

marcpopMSFT · 2026-07-01T23:13:15Z

Tested in codespaces for both --version and global.json.

marcpopMSFT · 2026-07-01T23:14:04Z

@copilot can you revert the changes to WorkloadSearchVersionsCommandDefniition.cs and the matching string changes? I believe we only care about the --version flag on workload operations or in global.json and don't care about catching this in search

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

Copilot · 2026-07-01T23:26:41Z

@copilot can you revert the changes to WorkloadSearchVersionsCommandDefniition.cs and the matching string changes? I believe we only care about the --version flag on workload operations or in global.j...

Addressed in da7042f: reverted the workload search validation and matching command-definition resource/XLF changes. I also updated the workload install/global.json error text so it no longer contradicts valid four-part suggestions, and fixed the MSTest data-driven test that surfaced during validation.

- Use System.Version.TryParse instead of manual int.TryParse for version component parsing in IsWorkloadSetVersionInPackageVersionFormat - Merge duplicate error strings (WorkloadSetVersionInPackageVersionFormat and WorkloadSetVersionInPackageVersionFormatGlobalJson) into a single string with an optional suffix for global.json context - Use else if for cleaner control flow between command-line and global.json version checks - Improve CS0436 pragma comment to be more specific about the cause Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Instead of suppressing CS0436 with a pragma, remove the duplicate Compile Include from dotnet.csproj. The class is already available through the project reference to Microsoft.DotNet.Cli.Definitions which has InternalsVisibleTo for dotnet. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI and others added 2 commits June 22, 2026 21:11

Detect wrong workload set version format with helpful error message

a6a4657

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

Address code review: improve pragma comment and prerelease suffix com…

77bef68

…ment Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

Copilot AI assigned Copilot and marcpopMSFT Jun 22, 2026

Copilot AI changed the title ~~Detect wrong workload set version format with helpful error message~~ Better error when workload set version uses package version format Jun 22, 2026

Copilot finished work on behalf of marcpopMSFT June 22, 2026 21:13

Copilot created this pull request from a session on behalf of marcpopMSFT June 22, 2026 21:13 View session

Copilot AI requested a review from marcpopMSFT June 22, 2026 21:13

Copilot started work on behalf of marcpopMSFT June 22, 2026 21:34 View session

Fix CI build errors: replace range indexer for net472 compatibility, …

77a1a0e

…convert xUnit tests to MSTest Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

Copilot finished work on behalf of marcpopMSFT June 22, 2026 21:43

build-analysis Bot mentioned this pull request Jun 22, 2026

One process not started with aspire integ test #54921

Closed

marcpopMSFT marked this pull request as ready for review July 1, 2026 23:04

Copilot AI review requested due to automatic review settings July 1, 2026 23:04

Copilot started reviewing on behalf of marcpopMSFT July 1, 2026 23:05 View session

Merge branch 'main' into copilot/detect-invalid-version-format

ed9b69f

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread src/Cli/dotnet/Commands/CliCommandStrings.resx Outdated

Comment thread src/Cli/Microsoft.DotNet.Cli.Definitions/CommandDefinitionStrings.resx Outdated

Copilot started work on behalf of marcpopMSFT July 1, 2026 23:14 View session

Revert workload search validation and clarify version message

da7042f

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

Copilot finished work on behalf of marcpopMSFT July 1, 2026 23:27

marcpopMSFT requested a review from nagilson July 2, 2026 20:30

marcpopMSFT added Area-CLI Area-Workloads labels Jul 14, 2026

marcpopMSFT enabled auto-merge (squash) July 14, 2026 23:48

nagilson reviewed Jul 16, 2026

View reviewed changes

Comment thread src/Cli/dotnet/Commands/Workload/InstallingWorkloadCommand.cs Outdated

Comment thread src/Cli/dotnet/Commands/Workload/InstallingWorkloadCommand.cs Outdated

Comment thread src/Common/WorkloadSetVersion.cs

marcpopMSFT requested a review from a team as a code owner July 23, 2026 22:14

marcpopMSFT requested a review from nagilson July 23, 2026 22:34

dsplaisted reviewed Jul 24, 2026

View reviewed changes

Comment thread src/Cli/dotnet/Commands/Workload/InstallingWorkloadCommand.cs Outdated

dsplaisted approved these changes Jul 24, 2026

View reviewed changes

Retry CI - dotnet-watch test failures are unrelated to this PR

549a631

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

marcpopMSFT merged commit ed75fed into main Jul 24, 2026
28 checks passed

marcpopMSFT deleted the copilot/detect-invalid-version-format branch July 24, 2026 21:18

dotnet-maestro Bot mentioned this pull request Jul 25, 2026

[main] Source code updates from dotnet/sdk dotnet/dotnet#7964

Merged

dotnet-milestone-bot Bot added this to the 11.0-rc1 milestone Jul 26, 2026

Navigation Menu

Uh oh!

Better error when workload set version uses package version format - #54929

Better error when workload set version uses package version format#54929
marcpopMSFT merged 8 commits into
mainfrom
copilot/detect-invalid-version-format

Copilot AI commented Jun 22, 2026 •

edited

Loading

Uh oh!

marcpopMSFT commented Jun 22, 2026

Uh oh!

Copilot AI commented Jun 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

marcpopMSFT commented Jul 1, 2026

Uh oh!

marcpopMSFT commented Jul 1, 2026

Uh oh!

Copilot AI commented Jul 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Copilot AI commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Error messages

Uh oh!

marcpopMSFT commented Jun 22, 2026

Uh oh!

Copilot AI commented Jun 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

marcpopMSFT commented Jul 1, 2026

Uh oh!

marcpopMSFT commented Jul 1, 2026

Uh oh!

Copilot AI commented Jul 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Jun 22, 2026 •

edited

Loading