-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Install runtime(s) with dotnetup
#52649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nagilson
merged 29 commits into
dotnet:release/dnup
from
nagilson:nagilson-dnup-install-runtimes-impl
Feb 6, 2026
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
f5243cc
Phase 0 - separate out the shareable walkthrough and hive determinati…
nagilson 633e3e5
Phase 0 - Separate more walkthrough and installation itself into shar…
nagilson 63d5add
Phase 0 - installation decision workflow shared
nagilson c8256a6
Phase 1 - add command
nagilson 5861b70
Add tests - needs QA - see comment for more detail
nagilson 930de36
Fix tests - but they need more QA now
nagilson 5c46517
remove a ton of bloated tests from ai
nagilson d19dc79
Remove hardcoded SDK texts
nagilson a2455b7
Consolidate shared test code for e2e sdk vs runtime
nagilson c54dcd9
specific failure message for runtime trying to use feature band
nagilson 35e31ee
Don't download runtime again if the sdk installed it already
nagilson f31de1d
Fix global.json parse + add test
nagilson b0822e2
dotnetup library installs runtimes
nagilson f7b1acf
share progress reporter to avoid extra \n
nagilson 46bd718
PR Feedback from Myself
nagilson 3a7c9ae
Block windowsdesktop runtime install on unix
nagilson f300d5a
Try to further simplify workflow code to be more readable
nagilson 5766bd9
Fix test
nagilson ca43c19
Mock download operations for more thorough tests
nagilson 80b904b
Fix comment
nagilson 8515b67
Merge remote-tracking branch 'upstream/release/dnup' into nagilson-dn…
nagilson bff81a4
post merge fix
nagilson 2743072
fix display calls
nagilson 3662da7
Merge branch 'nagilson-install-runtimes' into nagilson-dnup-install-r…
nagilson 08ef3be
Migrate to implementation of new design spec
nagilson 5934697
Fix CI issue with temp directory
nagilson ecd1638
Merge branch 'release/dnup' into nagilson-dnup-install-runtimes-impl
nagilson fa8fab4
PR feedback
nagilson 4d5d00a
move up admin install prompt
nagilson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
src/Installer/Microsoft.Dotnet.Installation/Internal/IArchiveDownloader.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using Microsoft.Deployment.DotNet.Releases; | ||
|
|
||
| namespace Microsoft.Dotnet.Installation.Internal; | ||
|
|
||
| /// <summary> | ||
| /// Interface for downloading .NET archives. Enables testing without network access. | ||
| /// </summary> | ||
| internal interface IArchiveDownloader : IDisposable | ||
| { | ||
| /// <summary> | ||
| /// Downloads the archive for the specified installation request and verifies its hash. | ||
| /// </summary> | ||
| /// <param name="installRequest">The installation request containing component and install root info.</param> | ||
| /// <param name="resolvedVersion">The resolved version to download.</param> | ||
| /// <param name="destinationPath">The local path to save the downloaded file.</param> | ||
| /// <param name="progress">Optional progress reporting.</param> | ||
| void DownloadArchiveWithVerification( | ||
| DotnetInstallRequest installRequest, | ||
| ReleaseVersion resolvedVersion, | ||
| string destinationPath, | ||
| IProgress<DownloadProgress>? progress = null); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.