Remove unused command resolver and parser files #51889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following PR #51661, this removes additional unused files: - TopLevelCommandParserResult.cs - internal class with no references - OutputPathCommandResolver.cs - unused command resolver - PathCommandResolverPolicy.cs - unused command resolver policy - DepsJsonCommandResolver.cs - unused command resolver Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove additional unused files from the repository
Remove unused command resolver and parser files
Nov 24, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes four unused files from the command resolution infrastructure as a follow-up to PR #51661. The removed files contain command resolvers and a parser result class that are never instantiated or referenced anywhere in the codebase.
Key changes:
- Removed
TopLevelCommandParserResult.cs- an internal class with no references - Removed three command resolver classes (
OutputPathCommandResolver,PathCommandResolverPolicy,DepsJsonCommandResolver) that are not wired into the active resolver policies (DefaultCommandResolverPolicyorScriptCommandResolverPolicy)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TopLevelCommandParserResult.cs | Removed unused internal parser result class that was never instantiated |
| PathCommandResolverPolicy.cs | Removed unused resolver policy that was never instantiated or used by command resolution pipeline |
| OutputPathCommandResolver.cs | Removed unused path-based command resolver that extended AbstractPathBasedCommandResolver but was never added to any composite resolver |
| DepsJsonCommandResolver.cs | Removed unused deps.json-based command resolver that was never integrated into the command resolution pipeline |
Member
|
@dsplaisted I asked copilot to identify and remove unused code. Here's what it came up with. Since things build, that's the only validation we really have. I did a search internally and externally and the only references I found externally were clones/forks of our own repos. Seems safe enough. |
Member
dsplaisted
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #51661 (StatInterop.cs removal). Identified and removed additional dead code with no references in the codebase.
Files Removed
These resolvers are not wired into
DefaultCommandResolverPolicyorScriptCommandResolverPolicy. Verified via grep that no code references these types.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.