Skip to content

dotnet SIGTERM signal handler registration - #50983

Merged
marcpopMSFT merged 4 commits into
dotnet:release/10.0.1xxfrom
tmat:DotnetSIGTERM
Sep 26, 2025
Merged

dotnet SIGTERM signal handler registration#50983
marcpopMSFT merged 4 commits into
dotnet:release/10.0.1xxfrom
tmat:DotnetSIGTERM

Conversation

@tmat

@tmat tmat commented Sep 24, 2025

Copy link
Copy Markdown
Member

Description

Fixes regression caused by a breaking change as recommended in dotnet/docs#46226.

Fixes #50965

Customer Impact

Impacts customers using dotnet-watch on Unix. dotnet-watch is unable to gracefully terminate the target process.

Regression?

  • Yes
  • No

Regressed from .NET 9 due to dotnet/docs#46226

Risk

  • High
  • Medium
  • Low

Justification: The change registers POSIX signal handler since the runtime does not register it by default anymore.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@github-actions

Copy link
Copy Markdown
Contributor

This PR is targeting main, which is now for .NET 11-facing work. If you intended to target .NET 10, either retarget this PR to release/10.0.1xx or make sure you backport the change to release/10.0.1xx after merging. See #50394 for more details.

@tmat
tmat changed the base branch from main to release/10.0.1xx September 24, 2025 16:55
Comment thread src/Cli/dotnet/Program.cs
Comment thread src/Cli/dotnet/Program.cs
@tmat
tmat marked this pull request as ready for review September 24, 2025 19:09
@tmat tmat changed the title Dotnet sigterm dotnet SIGTERM signal handler registration Sep 24, 2025
@tmat
tmat marked this pull request as draft September 24, 2025 19:20
@tmat
tmat force-pushed the DotnetSIGTERM branch 2 times, most recently from c126b90 to 629e887 Compare September 24, 2025 21:53
@tmat
tmat marked this pull request as ready for review September 24, 2025 23:17
@tmat
tmat requested a review from a team as a code owner September 24, 2025 23:17
Comment thread test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs
@marcpopMSFT
marcpopMSFT merged commit 161caf7 into dotnet:release/10.0.1xx Sep 26, 2025
24 of 27 checks passed
@marcpopMSFT

Copy link
Copy Markdown
Member

Known GenerateBundle task failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants