-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add alpha branding #50468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alpha branding #50468
Conversation
|
This PR is targeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the versioning configuration to add alpha branding by incrementing the major version from 10 to 11 and changing the pre-release label from "rc" (release candidate) to "alpha".
- Incremented major version from 10 to 11
- Changed pre-release label from "rc" to "alpha" for unstable packages
| </PropertyGroup> | ||
|
|
||
| <Exec Command='"$(DotNetTool)" "$(_GenerateDocumentationAndConfigFilesPath)" "-validateOnly:$(ValidateOnlyFlag)" "$(GeneratedRulesetsDir)" "$(GeneratedEditorconfigsDir)" "$(GeneratedGlobalAnalyzerConfigsDir)" "$(ArtifactsBinDir)$(EscapeDirectorySuffix)" "$(Configuration)" "$(TargetFramework)" "@(AnalyzerNupkgAssembly)" "$(PackagePropsTargetsFileDir)" "$(PackagePropsFileName)" "$(PackagePropsTargetsFileDir)" "$(PackageTargetsFileName)" "$(DisableNETAnalyzersPackagePropsFileName)" "$(AnalyzerDocumentationFileDir)" "$(AnalyzerDocumentationFileName)" "$(AnalyzerSarifFileDir)" "$(AnalyzerSarifFileName)" "$(VersionPrefix)" $(PackageId) $(ContainsPortedFxCopRules) $(GenerateAnalyzerRulesMissingDocumentationFile) $(ReleaseTrackingOptOut) $(_ValidateOffline)' /> | ||
| <Exec Command='"$(DotNetTool)" "$(_GenerateDocumentationAndConfigFilesPath)" "-validateOnly:$(ValidateOnlyFlag)" "$(GeneratedRulesetsDir)" "$(GeneratedEditorconfigsDir)" "$(GeneratedGlobalAnalyzerConfigsDir)" "$(ArtifactsBinDir)$(EscapeDirectorySuffix)" "$(Configuration)" "$(TargetFramework)" "@(AnalyzerNupkgAssembly)" "$(PackagePropsTargetsFileDir)" "$(PackagePropsFileName)" "$(PackagePropsTargetsFileDir)" "$(PackageTargetsFileName)" "$(DisableNETAnalyzersPackagePropsFileName)" "$(AnalyzerDocumentationFileDir)" "$(AnalyzerDocumentationFileName)" "$(AnalyzerSarifFileDir)" "$(AnalyzerSarifFileName)" "$(LatestVersionPrefix)" $(PackageId) $(ContainsPortedFxCopRules) $(GenerateAnalyzerRulesMissingDocumentationFile) $(ReleaseTrackingOptOut) $(_ValidateOffline)' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure to record this in the main tracking issue as this is a new item we'll need to unwind as we move to 11 that we didn't have last year
|
@tmat @dotnet/run-file There are a lot of watch and runfile tests that appear to depend on a hardcoded version check. Can ya'll take a look at fixing that so we can rebrand to 11 (and in the future, more easily to 12)? |
It should be as easy as changing the following I believe:
At least that's what I've been using for run-file tests (but it's a pre-existing constant that many other tests are also using). Should we be using something else? |
|
@jjonescz we don't have net11 templates yet. Can we retarget all these tests to 10 for now using a PreviousTargetFramework value and then find/replace that later? |
|
Looking closer, some basic run-file tests (like error NETSDK1045: The current .NET SDK does not support targeting .NET 11.0. Either target .NET 10.0 or lower, or use a version of the .NET SDK that supports .NET 11.0. Download the .NET SDK from https://aka.ms/dotnet/download Is that expected to be broken? We could add an explicit I guess the problem is that you want to brand the SDK as 11.* but keep the "current" TFM as net10.0? The I can just change computation of this property:
|
|
@tmat, could you please take a look at these failure dotnet-watch cases: |
Got it! We will do it! |
|
@marcpopMSFT I had disabled the failing test cases and using #51491 to track them. |
|
Same issue as #51557 |
src/Layout/Directory.Build.targets
Outdated
| <PgoTerm Condition="'$(PgoInstrument)' == 'true'">-pgo</PgoTerm> | ||
| <ArtifactNameWithVersionSdk>dotnet-sdk-internal$(PgoTerm)-$(FullNugetVersion)-$(ProductMonikerRid)</ArtifactNameWithVersionSdk> | ||
| <!-- <ArtifactNameWithVersionSdk>dotnet-sdk-internal$(PgoTerm)-$(FullNugetVersion)-$(ProductMonikerRid)</ArtifactNameWithVersionSdk> --> | ||
| <ArtifactNameWithVersionSdk>dotnet-sdk-internal$(PgoTerm)-10.0.100-rc.1-$(ProductMonikerRid)</ArtifactNameWithVersionSdk> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonnaChen888 Looks like this was created back when rc.1 was publicly available. With GA releasing tomorrow, let's update all of the spots we have rc.1 to point at the GA versions and try to get this merged later this week.
It's passing all checks (other than known failures) so I think we're good to go later this week. I just didn't want it to go in with rc.1 which was a while ago now.
|
@DonnaChen888 I think the last leg is just hitting our known templating issue but I can't tell if there are any real failure in there. We're free to merge this once the build analysis check passes. |
No description provided.