Skip to content

[main] Update dependencies from nuget/nuget.client #49743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 11, 2025

This pull request updates the following dependencies

From https://github.com/nuget/nuget.client

  • Updates:
    • From 7.0.0-preview.1.28 to 7.0.0-preview.1.46
      • Microsoft.Build.NuGetSdkResolver
      • NuGet.Build.Tasks
      • NuGet.Build.Tasks.Console
      • NuGet.Build.Tasks.Pack
      • NuGet.CommandLine.XPlat
      • NuGet.Commands
      • NuGet.Common
      • NuGet.Configuration
      • NuGet.Credentials
      • NuGet.DependencyResolver.Core
      • NuGet.Frameworks
      • NuGet.LibraryModel
      • NuGet.Localization
      • NuGet.Packaging
      • NuGet.ProjectModel
      • NuGet.Protocol
      • NuGet.Versioning

…7.0.0.31

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 7.0.0-preview.1.28 -> To Version 7.0.0-preview.1.31
dotnet-maestro bot and others added 2 commits July 12, 2025 12:30
…7.0.0.36

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 7.0.0-preview.1.28 -> To Version 7.0.0-preview.1.36
@SimonZhao888
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-maestro bot and others added 2 commits July 15, 2025 12:24
…7.0.0.37

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 7.0.0-preview.1.28 -> To Version 7.0.0-preview.1.37
@nagilson nagilson added the Area-Containers Related to dotnet SDK containers functionality label Jul 15, 2025
@nagilson nagilson enabled auto-merge July 15, 2025 16:53
@SimonZhao888
Copy link
Member

SimonZhao888 commented Jul 16, 2025

Test case Packing_a_netcoreapp_2_0_DotnetCliTool_app_includes_the_implicit_dependency() fails due to the following method does not modify the denpendency as in the main branch.

testProject.AdditionalProperties.Add("PackageType", "DotnetCliTool");

Main branch:
image
This PR:
image
So the test case will return an empty array at PackAndGetDependencies() method.
private List<XElement> PackAndGetDependencies(TestProject testProject, string identifier = null)
{
var dependencyGroups = GetDependencyGroups(PackAndGetNuspec(testProject, identifier), out var ns);
// There should be only one dependency group for these tests
dependencyGroups.Count().Should().Be(1);
// It should have the right element name
dependencyGroups.Single().Name.Should().Be(ns + "group");
var dependencies = dependencyGroups.Single().Elements(ns + "dependency").ToList();
return dependencies;
}

@nagilson, @MiYanni, could you please take a look at this?

…7.0.0.46

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 7.0.0-preview.1.28 -> To Version 7.0.0-preview.1.46
@baronfel
Copy link
Member

Thanks for the connection to this @jjonescz - I think this needs to be merged into the VMR codeflow PR in order for either of them to succeed.

@jjonescz
Copy link
Member

I've merged changes from this PR into #49740.

@nkolev92
Copy link
Contributor

Test case Packing_a_netcoreapp_2_0_DotnetCliTool_app_includes_the_implicit_dependency() fails due to the following method does not modify the denpendency as in the main branch.

testProject.AdditionalProperties.Add("PackageType", "DotnetCliTool");

Main branch:
image
This PR:
image
So the test case will return an empty array at PackAndGetDependencies() method.

private List<XElement> PackAndGetDependencies(TestProject testProject, string identifier = null)
{
var dependencyGroups = GetDependencyGroups(PackAndGetNuspec(testProject, identifier), out var ns);
// There should be only one dependency group for these tests
dependencyGroups.Count().Should().Be(1);
// It should have the right element name
dependencyGroups.Single().Name.Should().Be(ns + "group");
var dependencies = dependencyGroups.Single().Elements(ns + "dependency").ToList();
return dependencies;
}

@nagilson, @MiYanni, could you please take a look at this?

This is expected with the new pruning feature.

A direct package that can be pruned will be excluded out of the generated package.

I don't imagine the package needs to be referencing netcoreapp package is it?

So either adjust the expectation or just set RestoreEnablePackagePruning to false in that test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow Area-Containers Related to dotnet SDK containers functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants