Disallow duplicate file-level directives #49308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR enforces uniqueness among file-level directives by disallowing duplicates, resolving issue #48842.
- Added tests in DotnetProjectConvertTests.cs to validate duplicate directive detection.
- Introduced deduplication logic using a HashSet with a custom NamedDirectiveComparer in VirtualProjectBuildingCommand.cs.
- Updated localization resources (XLF and RESX files) to include error messages for duplicate directives.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Project/Convert/DotnetProjectConvertTests.cs | Added tests to confirm duplicate file-level directive errors are raised correctly. |
| src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs | Implemented deduplication logic by comparing directive type and name. |
| src/Cli/dotnet/Commands/xlf/* | Added DuplicateDirective entries to localization files. |
| src/Cli/dotnet/Commands/CliCommandStrings.resx | Introduced the DuplicateDirective resource entry. |
jaredpar
approved these changes
Jun 10, 2025
|
seeing similar CI failures here as in #48387, is there some known issue preventing those dotnet watch tests from succeeding across the board? |
RikkiGibson
approved these changes
Jun 10, 2025
Yes, see #49307. |
|
@MiYanni for a review, thanks |
MiYanni
approved these changes
Jun 11, 2025
3 tasks
|
Failures are in watch tests which are known, containers test which are known, and a completion test which is known. Merging per request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #48842.