-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update branding to 9.0.108 #49245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update branding to 9.0.108 #49245
Conversation
@dotnet/source-build The source build leg was getting flagged for a known vulnerability in msbuild 17.8.3. Do you know why source build is using a 17.8 msbuild when 9.0 shipped with 17.12? I updated it to 17.8.29 as the latest 17.8 version but wanted to double check that it should even be a 17.8 version. |
I noticed this looks like the same issue being discussed in issue #48964, and it seems like @NikolaMilosavljevic is already following up on it — maybe we can move the discussion over there instead? |
The other, linked issue was about Arcade's use of MSBuild packages at 17.8 level - I have updated the Arcade dependencies with dotnet/arcade#15843 - I'll check why this is still being flagged. |
Last arcade flow was on 5/13 - 5c414b7 My fix for MSBuild dependencies in arcade was merged on 5/16. Perhaps the subscription is manual - @marcpopMSFT @mmitche |
The subscriptions are set to manual trigger for Arcade. We usually trigger them on a monthly update on Patch Tuesday. We can trigger this for 9.0 now though, no problem. |
#48964 from a few weeks ago |
…6.12.4.9 Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning From Version 6.12.4-rc.1 -> To Version 6.12.4-rc.9
I cherry picked the nuget flow to fix the source build leg into this PR and cherry-picked the templating fix to fix those tests. Let's see if that gets us a cleaner build. |
Ported in the arcade flow as well as SB was failing in the arcade build step: https://github.com/dotnet/sdk/pull/48964/files#diff-8df3cd354bc584349d04ad5675b33c042d8b99b741b8b95af394c55e0f5001bf |
You'll need the updated to Version.Details.xml too |
26f6ab0
to
60fab25
Compare
I'd pushed to the wrong place as I'd forgotten this was on sean's fork. Force pushing the arcade changes to his branch. |
source build passed. Remaining failure was a test timeout in a test we have a PR to speed up: #48405. Merging on red |
No description provided.