Skip to content

Update branding to 9.0.108 #49245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vseanreesermsft
Copy link
Contributor

No description provided.

@marcpopMSFT marcpopMSFT requested review from a team as code owners June 4, 2025 20:33
@marcpopMSFT
Copy link
Member

@dotnet/source-build The source build leg was getting flagged for a known vulnerability in msbuild 17.8.3. Do you know why source build is using a 17.8 msbuild when 9.0 shipped with 17.12? I updated it to 17.8.29 as the latest 17.8 version but wanted to double check that it should even be a 17.8 version.

@v-wuzhai
Copy link
Member

v-wuzhai commented Jun 5, 2025

I noticed this looks like the same issue being discussed in issue #48964, and it seems like @NikolaMilosavljevic is already following up on it — maybe we can move the discussion over there instead?

@NikolaMilosavljevic
Copy link
Member

I noticed this looks like the same issue being discussed in issue #48964, and it seems like @NikolaMilosavljevic is already following up on it — maybe we can move the discussion over there instead?

The other, linked issue was about Arcade's use of MSBuild packages at 17.8 level - I have updated the Arcade dependencies with dotnet/arcade#15843 - I'll check why this is still being flagged.

@NikolaMilosavljevic
Copy link
Member

I noticed this looks like the same issue being discussed in issue #48964, and it seems like @NikolaMilosavljevic is already following up on it — maybe we can move the discussion over there instead?

The other, linked issue was about Arcade's use of MSBuild packages at 17.8 level - I have updated the Arcade dependencies with dotnet/arcade#15843 - I'll check why this is still being flagged.

Last arcade flow was on 5/13 - 5c414b7 My fix for MSBuild dependencies in arcade was merged on 5/16. Perhaps the subscription is manual - @marcpopMSFT @mmitche

@mmitche
Copy link
Member

mmitche commented Jun 6, 2025

The subscriptions are set to manual trigger for Arcade. We usually trigger them on a monthly update on Patch Tuesday. We can trigger this for 9.0 now though, no problem.

@mmitche
Copy link
Member

mmitche commented Jun 6, 2025

#48964 from a few weeks ago

dotnet-maestro bot and others added 2 commits June 9, 2025 16:54
…6.12.4.9

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 6.12.4-rc.1 -> To Version 6.12.4-rc.9
@marcpopMSFT marcpopMSFT requested a review from a team as a code owner June 9, 2025 23:55
@marcpopMSFT
Copy link
Member

I cherry picked the nuget flow to fix the source build leg into this PR and cherry-picked the templating fix to fix those tests. Let's see if that gets us a cleaner build.

@marcpopMSFT
Copy link
Member

Ported in the arcade flow as well as SB was failing in the arcade build step: https://github.com/dotnet/sdk/pull/48964/files#diff-8df3cd354bc584349d04ad5675b33c042d8b99b741b8b95af394c55e0f5001bf

@mmitche
Copy link
Member

mmitche commented Jun 10, 2025

Ported in the arcade flow as well as SB was failing in the arcade build step: https://github.com/dotnet/sdk/pull/48964/files#diff-8df3cd354bc584349d04ad5675b33c042d8b99b741b8b95af394c55e0f5001bf

You'll need the updated to Version.Details.xml too

@marcpopMSFT marcpopMSFT force-pushed the branding-9.0.108-2025-06-04-0922-0fb9fc09-f716-469c-a226-e51e20c55734 branch from 26f6ab0 to 60fab25 Compare June 10, 2025 17:05
@marcpopMSFT
Copy link
Member

I'd pushed to the wrong place as I'd forgotten this was on sean's fork. Force pushing the arcade changes to his branch.

@marcpopMSFT
Copy link
Member

source build passed. Remaining failure was a test timeout in a test we have a PR to speed up: #48405. Merging on red

@marcpopMSFT marcpopMSFT merged commit 3f1d7f7 into dotnet:release/9.0.1xx Jun 10, 2025
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants