Add container with SDK and scancode preinstalled #48622
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
Pull Request Overview
This PR adds a container image with the .NET SDK and scancode preinstalled to address issue dotnet/source-build#3816.
- Added a new container definition named "ubuntusdkamd64container" with the appropriate image.
- Updated the LicenseScan job to reference a container and removed redundant installation steps for the .NET SDK and scancode.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| - task: PipAuthenticate@1 | ||
| displayName: 'Pip Authenticate' | ||
| inputs: | ||
| artifactFeeds: public/dotnet-public-pypi | ||
| onlyAddExtraIndex: false | ||
|
|
||
| - script: $(sdkRoot)/eng/install-scancode.sh |
There was a problem hiding this comment.
Is anything still using this file, can it be removed?
There was a problem hiding this comment.
I searched for the keyword "scancode" in the source build repository and found that only the license scan test is using this toolkit.
There was a problem hiding this comment.
Does that confirm that it can be removed with this PR?
There was a problem hiding this comment.
Yes, that script file should be deleted.
There was a problem hiding this comment.
I thought I had removed this file in the previous update to the PR, but it looks like I missed it. I 've now included the update: f18dd2f
| @@ -52,6 +52,9 @@ extends: | |||
| name: NetCore1ESPool-Svc-Internal | |||
| image: 1es-ubuntu-2204 | |||
| os: linux | |||
| containers: | |||
| ubuntusdkamd64container: | |||
There was a problem hiding this comment.
| ubuntusdkamd64container: | |
| ubuntuSdkAmd64Container: |
| - task: PipAuthenticate@1 | ||
| displayName: 'Pip Authenticate' | ||
| inputs: | ||
| artifactFeeds: public/dotnet-public-pypi | ||
| onlyAddExtraIndex: false |
Fixes dotnet/source-build#3816
Add the specifially container image with .NET SDK and scancode preinstalled.
Related to dotnet/dotnet-buildtools-prereqs-docker#1408