-
Notifications
You must be signed in to change notification settings - Fork 1.1k
update template descriptions to be more beginner-friendly #48609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates template descriptions in the .NET template engine and corresponding tests to be more beginner-friendly.
- Updated descriptions for the console and class library templates.
- Adjusted documentation strings in various approval tests to reflect clearer, simplified language.
Reviewed Changes
Copilot reviewed 7 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
test/dotnet-new.IntegrationTests/Approvals/DotnetNewHelpTests.CanShowHelpForTemplate_console.verified.txt | Console app description updated. |
test/dotnet-new.IntegrationTests/Approvals/DotnetNewHelpTests.CanShowHelpForTemplate_classlib.verified.txt | Class library description updated. |
test/dotnet-new.IntegrationTests/Approvals/DotnetNewHelpTests.CanShowHelpForTemplate_MatchOnLanguage.verified.txt | Console app (F#) description updated. |
test/dotnet-new.IntegrationTests/Approvals/DotnetNewHelpTests.CanShowHelpForTemplate_MatchOnChoice.verified.txt | Console app description updated. |
test/Microsoft.TemplateEngine.Cli.UnitTests/ParserTests/Approvals/TabCompletionTests.RootCommand_GetStartsWtihSuggestions.verified.txt | Documentation string updated for class library and console templates. |
test/Microsoft.TemplateEngine.Cli.UnitTests/ParserTests/Approvals/TabCompletionTests.RootCommand_GetAllSuggestions.verified.txt | Documentation string updated for class library and console templates. |
test/Microsoft.TemplateEngine.Cli.UnitTests/ParserTests/Approvals/TabCompletionTests.Create_GetAllSuggestions.verified.txt | Documentation string updated for class library and console templates. |
Files not reviewed (13)
- template_feed/Microsoft.DotNet.Common.ProjectTemplates.10.0/content/ClassLibrary-CSharp/.template.config/localize/templatestrings.en.json: Language not supported
- template_feed/Microsoft.DotNet.Common.ProjectTemplates.10.0/content/ClassLibrary-CSharp/.template.config/template.json: Language not supported
- template_feed/Microsoft.DotNet.Common.ProjectTemplates.10.0/content/ClassLibrary-FSharp/.template.config/localize/templatestrings.en.json: Language not supported
- template_feed/Microsoft.DotNet.Common.ProjectTemplates.10.0/content/ClassLibrary-FSharp/.template.config/template.json: Language not supported
- template_feed/Microsoft.DotNet.Common.ProjectTemplates.10.0/content/ClassLibrary-VisualBasic/.template.config/localize/templatestrings.en.json: Language not supported
- template_feed/Microsoft.DotNet.Common.ProjectTemplates.10.0/content/ClassLibrary-VisualBasic/.template.config/template.json: Language not supported
- template_feed/Microsoft.DotNet.Common.ProjectTemplates.10.0/content/ConsoleApplication-CSharp/.template.config/localize/templatestrings.en.json: Language not supported
- template_feed/Microsoft.DotNet.Common.ProjectTemplates.10.0/content/ConsoleApplication-CSharp/.template.config/template.json: Language not supported
- template_feed/Microsoft.DotNet.Common.ProjectTemplates.10.0/content/ConsoleApplication-FSharp/.template.config/localize/templatestrings.en.json: Language not supported
- template_feed/Microsoft.DotNet.Common.ProjectTemplates.10.0/content/ConsoleApplication-FSharp/.template.config/template.json: Language not supported
- template_feed/Microsoft.DotNet.Common.ProjectTemplates.10.0/content/ConsoleApplication-VisualBasic/.template.config/localize/templatestrings.en.json: Language not supported
- template_feed/Microsoft.DotNet.Common.ProjectTemplates.10.0/content/ConsoleApplication-VisualBasic/.template.config/template.json: Language not supported
- test/dotnet-new.IntegrationTests/Approvals/DotnetNewHelpTests.CanShowHelpForTemplate_MatchOnNonChoiceParam.verified.txt: Language not supported
...w.IntegrationTests/Approvals/DotnetNewHelpTests.CanShowHelpForTemplate_classlib.verified.txt
Outdated
Show resolved
Hide resolved
...s/ParserTests/Approvals/TabCompletionTests.RootCommand_GetStartsWtihSuggestions.verified.txt
Outdated
Show resolved
Hide resolved
...nitTests/ParserTests/Approvals/TabCompletionTests.RootCommand_GetAllSuggestions.verified.txt
Outdated
Show resolved
Hide resolved
...Cli.UnitTests/ParserTests/Approvals/TabCompletionTests.Create_GetAllSuggestions.verified.txt
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
...Templates.10.0/content/ClassLibrary-CSharp/.template.config/localize/templatestrings.en.json
Outdated
Show resolved
Hide resolved
...rojectTemplates.10.0/content/MSTest-CSharp/.template.config/localize/templatestrings.en.json
Outdated
Show resolved
Hide resolved
thank you for your feedback @KalleOlaviNiemitalo! Re-requesting review :) |
Making this change so that template descriptions in the .NET template engine can be more beginner-friendly