-
Notifications
You must be signed in to change notification settings - Fork 1.1k
dotnet test for MTP: Support TestTfmsInParallel #48246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 10 out of 13 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- test/TestAssets/TestProjects/TestProjectWithMultipleTFMsParallelization/TestProject/TestProject.csproj: Language not supported
- test/TestAssets/TestProjects/TestProjectWithMultipleTFMsParallelization/TestProjectWithMultipleTFMsParallelization.sln: Language not supported
- test/TestAssets/TestProjects/TestProjectWithMultipleTFMsParallelization/dotnet.config: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fill in more details about the motivation, here or in the issue that is being fixed? Is this customer ask? Is this feature partity with vstest? To me the behavior of not running test projects in parallel when parallel run is enabled (default) seems undesirable, so I am probably missing some context.
Some projects access shared database and/or file system, for which case users are setting TestTfmsInParallel to false. This already works in MTP for the existing |
Fixes #47496
TestTfmsInParallel was already supported in MTP with the old
dotnet test
as we are hooking into existing VSTest infrastructure. This brings feature parity.