Skip to content

dotnet test for MTP: Support TestTfmsInParallel #48246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 9, 2025

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Apr 8, 2025

Fixes #47496

TestTfmsInParallel was already supported in MTP with the old dotnet test as we are hooking into existing VSTest infrastructure. This brings feature parity.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-dotnet test untriaged Request triage from a team member labels Apr 8, 2025
@Youssef1313 Youssef1313 marked this pull request as ready for review April 8, 2025 13:02
@Copilot Copilot AI review requested due to automatic review settings April 8, 2025 13:02
@Youssef1313 Youssef1313 requested a review from a team as a code owner April 8, 2025 13:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 13 changed files in this pull request and generated 1 comment.

Files not reviewed (3)
  • test/TestAssets/TestProjects/TestProjectWithMultipleTFMsParallelization/TestProject/TestProject.csproj: Language not supported
  • test/TestAssets/TestProjects/TestProjectWithMultipleTFMsParallelization/TestProjectWithMultipleTFMsParallelization.sln: Language not supported
  • test/TestAssets/TestProjects/TestProjectWithMultipleTFMsParallelization/dotnet.config: Language not supported

Copy link
Member

@nohwnd nohwnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fill in more details about the motivation, here or in the issue that is being fixed? Is this customer ask? Is this feature partity with vstest? To me the behavior of not running test projects in parallel when parallel run is enabled (default) seems undesirable, so I am probably missing some context.

@Youssef1313
Copy link
Member Author

Youssef1313 commented Apr 8, 2025

Can you fill in more details about the motivation, here or in the issue that is being fixed? Is this customer ask? Is this feature partity with vstest? To me the behavior of not running test projects in parallel when parallel run is enabled (default) seems undesirable, so I am probably missing some context.

Some projects access shared database and/or file system, for which case users are setting TestTfmsInParallel to false. This already works in MTP for the existing dotnet test and I came across users relying on it, so this reduces friction when moving from the old dotnet test for MTP to the new one. See microsoft/testfx#4392 for example.

@Youssef1313 Youssef1313 requested a review from nohwnd April 9, 2025 08:04
@Youssef1313 Youssef1313 merged commit 4d95eec into main Apr 9, 2025
39 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/TestTfmsInParallel branch April 9, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-dotnet test untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure TestTfmsInParallel works for the new dotnet test experience
2 participants