Skip to content

[ApiDiff] Add static factory method to generate AssemblySymbolLoader #46380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 31, 2025
Merged

[ApiDiff] Add static factory method to generate AssemblySymbolLoader #46380

merged 4 commits into from
Jan 31, 2025

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Jan 29, 2025 •
edited
Loading

Follow up of #46255

This PR is part of the work needed to create an ApiDiff tool that reuses some of the code from Microsoft.DotNet.GenAPI. The idea is to make the larger PR smaller and make it easier to review: #45389

The proposed changes in this PR include:

  • Adding a static factory method to AssemblySymbolLoader to create instances.
  • Extracting the document generation logic from CSharpFileBuilder and into its own class. That specific code will be used in ApiDiff. CSharpFileBuilder behavior should remain the same.
  • Refactoring GenAPIApp and GenApiTask to generate a loader using the static method.
  • Modify the tests accordingly.

@carlossanlop carlossanlop self-assigned this Jan 29, 2025
@ghost ghost added Area-GenAPI untriaged Request triage from a team member labels Jan 29, 2025
This was referenced Jan 29, 2025
Open
Open
@carlossanlop carlossanlop mentioned this pull request Jan 29, 2025
Open
@carlossanlop carlossanlop marked this pull request as ready for review January 29, 2025 19:52
@carlossanlop carlossanlop requested a review from a team as a code owner January 29, 2025 19:52
@carlossanlop
Add static factory method for AssemblySymbolLoader.
a96f62f 
Extract the document generation logic into its own class.
Refactor GenAPIApp and GenApiTask to generate a loader using the static method.
@carlossanlop
Update tests
0362fb9
@carlossanlop
Fix a wrong slnf path
467d5db
@carlossanlop carlossanlop mentioned this pull request Jan 30, 2025
Merged
@carlossanlop carlossanlop removed the untriaged Request triage from a team member label Jan 30, 2025
michaelgsharp
michaelgsharp approved these changes Jan 31, 2025
View reviewed changes
Copy link

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@carlossanlop carlossanlop enabled auto-merge (squash) January 31, 2025 01:13
@carlossanlop carlossanlop merged commit a945fa6 into dotnet:main Jan 31, 2025
35 of 38 checks passed
@carlossanlop carlossanlop deleted the AssemblySymbolLoader branch January 31, 2025 01:33
@carlossanlop carlossanlop mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgsharp michaelgsharp michaelgsharp approved these changes

@ericstj ericstj Awaiting requested review from ericstj

@ViktorHofer ViktorHofer Awaiting requested review from ViktorHofer

Assignees

@carlossanlop carlossanlop

Labels
Area-GenAPI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @ViktorHofer @michaelgsharp