Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign the DAC and build (and sign) the cross-OS DACs in the VMR #46377

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
+103 −31
Open

Sign the DAC and build (and sign) the cross-OS DACs in the VMR #46377

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
c704989
Add steps to install, set up, and remove diagnostic certs for DAC sig…
jkoritzinsky Jan 28, 2025
f90b6bb
Forward down the ESRP tool path when we're doing real signing.
jkoritzinsky Jan 28, 2025
9e3c8bc
Add a win-x86 join job to run the cross-os DAC signing.
jkoritzinsky Jan 28, 2025
e661045
Add comments around the install/remove step templates.
jkoritzinsky Jan 29, 2025
0f5b16e
Add comments about our BuildPhase2 jobs
jkoritzinsky Jan 29, 2025
b515aa0
Pass down IsOfficialBuild variable
jkoritzinsky Jan 30, 2025
f1bd73b
Merge branch 'main' into dac-sign
jkoritzinsky Feb 3, 2025
24722b8
Merge branch 'main' into dac-sign
jkoritzinsky Feb 5, 2025
c555fff
Add patch to enable building runtime projects in BuildPass=2
jkoritzinsky Feb 5, 2025
6b06843
Update eng/pipelines/templates/stages/vmr-build.yml
jkoritzinsky Feb 5, 2025
6838590
Update patch
jkoritzinsky Feb 5, 2025
dc37e48
Update patch
jkoritzinsky Feb 6, 2025
c38d8a6
Merge branch 'main' of github.com:dotnet/sdk into dac-sign
jkoritzinsky Feb 6, 2025
48bb561
Rename patch file
jkoritzinsky Feb 6, 2025
161770a
Allow a repository to reference packages produced by itself in earlie…
jkoritzinsky Feb 6, 2025
044a914
Use RepositoryReferenceInfo instead for this case.
jkoritzinsky Feb 6, 2025
5748c30
Update task to understand "previous build pass" sources
jkoritzinsky Feb 7, 2025
760f202
Update tests
jkoritzinsky Feb 7, 2025
b3c142d
Remove patch
jkoritzinsky Feb 7, 2025
5d84d87
Fix double-dash
jkoritzinsky Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pass down IsOfficialBuild variable
  • Loading branch information
@jkoritzinsky
jkoritzinsky committed Jan 30, 2025
commit b515aa09ff71919bc6bc82001be67418dbd65d96
4 changes: 2 additions & 2 deletions eng/pipelines/templates/jobs/vmr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ jobs:
# TODO: Once we turn off the dotnet/runtime official build, move these templates into the VMR's eng folder.
- template: ${{ variables['Build.SourcesDirectory'] }}/src/runtime/eng/pipelines/coreclr/templates/install-diagnostic-certs.yml
jkoritzinsky marked this conversation as resolved.
Show resolved Hide resolved
parameters:
isOfficialBuild: true
isOfficialBuild: ${{ variables.isOfficialBuild }}
certNames:
- 'dotnetesrp-diagnostics-aad-ssl-cert'
- 'dotnet-diagnostics-esrp-pki-onecert'
Expand All @@ -394,7 +394,7 @@ jobs:
# TODO: Once we turn off the dotnet/runtime official build, move these templates into the VMR's eng folder.
- template: ${{ variables['Build.SourcesDirectory'] }}/src/runtime/eng/pipelines/coreclr/templates/remove-diagnostic-certs.yml
parameters:
isOfficialBuild: true
isOfficialBuild: ${{ variables.isOfficialBuild }}
scriptRoot: '$(Build.SourcesDirectory)/src/runtime'

- ${{ if eq(parameters.runTests, 'True') }}:
Expand Down
Loading