Skip to content

Add signing parameter to ci pipelines #46368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmitche merged 6 commits into from
Jan 29, 2025
Merged

Add signing parameter to ci pipelines #46368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9fc823
Add signing parameter to ci pipelines
mmitche Jan 28, 2025
4068418
Fixup bracing
mmitche Jan 28, 2025
68fe1c4
Fix indent
mmitche Jan 28, 2025
01a591f
Replace sign with signEnabled to avoid conflict with MSBuild property
mmitche Jan 28, 2025
0994e19
Skip signing validation if signing is disabled
mmitche Jan 29, 2025
bc83f4a
Update sign variable conditional
mmitche Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/pipelines/templates/jobs/vmr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ parameters:
default: false

- name: sign
displayName: True when build output should be signed
displayName: True when build output should be signed (includes dry runs)
type: boolean
default: true

Expand Down
52 changes: 45 additions & 7 deletions eng/pipelines/templates/stages/vmr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ parameters:
type: string
default: $(Build.SourceBranch)

- name: desiredSigning
type: string
default: ''

# Scope of jobs which are executed
- name: scope
type: string
Expand Down Expand Up @@ -390,13 +394,15 @@ stages:
- template: ../variables/vmr-build.yml
parameters:
vmrBranch: ${{ parameters.vmrBranch }}
desiredSigning: ${{ parameters.desiredSigning }}
jobs:

- template: ../jobs/vmr-build.yml
parameters:
buildName: Windows
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Windows }}
targetOS: windows
targetArchitecture: x64
Expand All @@ -406,6 +412,7 @@ stages:
buildName: Android_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux_Shortstack }}
container:
name: ${{ variables.androidCrossContainerName }}
Expand All @@ -418,6 +425,7 @@ stages:
buildName: Browser_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux_Shortstack }}
container:
name: ${{ variables.browserCrossContainerName }}
Expand All @@ -431,6 +439,7 @@ stages:
buildName: iOSSimulator_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Mac }}
targetOS: iossimulator
targetArchitecture: arm64
Expand All @@ -443,6 +452,7 @@ stages:
buildName: Android_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux_Shortstack }}
container:
name: ${{ variables.androidCrossContainerName }}
Expand All @@ -455,6 +465,7 @@ stages:
buildName: Android_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux_Shortstack }}
container:
name: ${{ variables.androidCrossContainerName }}
Expand All @@ -467,6 +478,7 @@ stages:
buildName: Android_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux_Shortstack }}
container:
name: ${{ variables.androidCrossContainerName }}
Expand All @@ -479,6 +491,7 @@ stages:
buildName: Browser_Multithreaded_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux_Shortstack }}
container:
name: ${{ variables.browserCrossContainerName }}
Expand All @@ -493,6 +506,7 @@ stages:
buildName: LinuxBionic_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux_Shortstack }}
container:
name: ${{ variables.linuxBionicCrossContainerName }}
Expand All @@ -506,6 +520,7 @@ stages:
buildName: LinuxBionic_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux_Shortstack }}
container:
name: ${{ variables.linuxBionicCrossContainerName }}
Expand All @@ -519,6 +534,7 @@ stages:
buildName: LinuxBionic_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux_Shortstack }}
container:
name: ${{ variables.linuxBionicCrossContainerName }}
Expand All @@ -532,6 +548,7 @@ stages:
buildName: iOS_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Mac }}
targetOS: ios
targetArchitecture: arm64
Expand All @@ -541,6 +558,7 @@ stages:
buildName: iOSSimulator_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Mac }}
targetOS: iossimulator
targetArchitecture: x64
Expand All @@ -550,15 +568,18 @@ stages:
buildName: MacCatalyst_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Mac }}
targetOS: maccatalyst
targetArchitecture: arm64
runTests: false

- template: ../jobs/vmr-build.yml
parameters:
buildName: MacCatalyst_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Mac }}
targetOS: maccatalyst
targetArchitecture: x64
Expand All @@ -568,6 +589,7 @@ stages:
buildName: tvOS_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Mac }}
targetOS: tvos
targetArchitecture: arm64
Expand All @@ -577,6 +599,7 @@ stages:
buildName: tvOSSimulator_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Mac }}
targetOS: tvossimulator
targetArchitecture: arm64
Expand All @@ -586,6 +609,7 @@ stages:
buildName: tvOSSimulator_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Mac }}
targetOS: tvossimulator
targetArchitecture: x64
Expand All @@ -595,6 +619,7 @@ stages:
buildName: Wasi_Shortstack
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux_Shortstack }}
container:
name: ${{ variables.wasiCrossContainerName }}
Expand All @@ -608,6 +633,7 @@ stages:
buildName: OSX
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Mac }}
targetOS: osx
targetArchitecture: x64
Expand All @@ -617,6 +643,7 @@ stages:
buildName: AzureLinux_x64_Cross
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux }}
container:
name: ${{ variables.azurelinuxX64CrossContainerName }}
Expand All @@ -630,6 +657,7 @@ stages:
buildName: AzureLinux_x64_Cross_Pgo
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: false
pool: ${{ parameters.pool_Linux }}
container:
name: ${{ variables.azurelinuxX64CrossContainerName }}
Expand All @@ -638,13 +666,13 @@ stages:
targetOS: linux
targetArchitecture: x64
extraProperties: /p:PgoInstrument=true
sign: false

- template: ../jobs/vmr-build.yml
parameters:
buildName: AzureLinux_x64_Cross_Shortstack_Mono_LLVMAOT
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux_Shortstack }}
container:
name: ${{ variables.azurelinuxX64CrossContainerName }}
Expand All @@ -660,6 +688,7 @@ stages:
buildName: AzureLinux_x64_Cross
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux }}
container:
name: ${{ variables.azurelinuxArmCrossContainerName }}
Expand All @@ -673,6 +702,7 @@ stages:
buildName: AzureLinux_x64_Cross
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux }}
container:
name: ${{ variables.azurelinuxArm64CrossContainerName }}
Expand All @@ -686,6 +716,7 @@ stages:
buildName: AzureLinux_x64_Cross_Pgo
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: false
pool: ${{ parameters.pool_Linux }}
container:
name: ${{ variables.azurelinuxArm64CrossContainerName }}
Expand All @@ -694,13 +725,13 @@ stages:
targetOS: linux
targetArchitecture: arm64
extraProperties: /p:PgoInstrument=true
sign: false

- template: ../jobs/vmr-build.yml
parameters:
buildName: AzureLinux_x64_Cross_Alpine
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux }}
container:
name: ${{ variables.azurelinuxX64AlpineCrossContainerName }}
Expand All @@ -715,6 +746,7 @@ stages:
buildName: AzureLinux_x64_Cross_Alpine
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux }}
container:
name: ${{ variables.azurelinuxArmAlpineCrossContainerName }}
Expand All @@ -729,6 +761,7 @@ stages:
buildName: AzureLinux_x64_Cross_Alpine
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux }}
container:
name: ${{ variables.azurelinuxArm64AlpineCrossContainerName }}
Expand All @@ -743,6 +776,7 @@ stages:
buildName: AzureLinux_x64_Cross_Shortstack_Mono_LLVMAOT
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Linux_Shortstack }}
container:
name: ${{ variables.azurelinuxArm64CrossContainerName }}
Expand All @@ -758,6 +792,7 @@ stages:
buildName: OSX
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Mac }}
targetOS: osx
targetArchitecture: arm64
Expand All @@ -767,6 +802,7 @@ stages:
buildName: Windows
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Windows }}
targetOS: windows
targetArchitecture: arm64
Expand All @@ -776,6 +812,7 @@ stages:
buildName: Windows
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Windows }}
targetOS: windows
targetArchitecture: x86
Expand All @@ -785,33 +822,33 @@ stages:
buildName: Windows_Pgo
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: false
pool: ${{ parameters.pool_Windows }}
targetOS: windows
targetArchitecture: x64
extraProperties: /p:PgoInstrument=true
sign: false

- template: ../jobs/vmr-build.yml
parameters:
buildName: Windows_Pgo
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: false
pool: ${{ parameters.pool_Windows }}
targetOS: windows
targetArchitecture: x86
extraProperties: /p:PgoInstrument=true
sign: false

- template: ../jobs/vmr-build.yml
parameters:
buildName: Windows_Pgo
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: false
pool: ${{ parameters.pool_Windows }}
targetOS: windows
targetArchitecture: arm64
extraProperties: /p:PgoInstrument=true
sign: false

# Build Pass 2 verticals

Expand All @@ -820,6 +857,7 @@ stages:
buildName: Windows
isBuiltFromVmr: ${{ parameters.isBuiltFromVmr }}
vmrBranch: ${{ variables.VmrBranch }}
sign: ${{ variables.signEnabled }}
pool: ${{ parameters.pool_Windows }}
targetOS: windows
targetArchitecture: x64
Expand Down Expand Up @@ -868,9 +906,9 @@ stages:
dotNetBuildPass: final
primaryDependentJob: Windows_x64
outputFolder: $(Build.ArtifactStagingDirectory)/artifacts

### VALIDATION ###
- ${{ if and(parameters.isBuiltFromVmr, not(parameters.isSourceOnlyBuild), eq(variables['System.TeamProject'], 'internal')) }}:
- ${{ if and(parameters.isBuiltFromVmr, not(parameters.isSourceOnlyBuild), eq(variables['System.TeamProject'], 'internal'), eq(variables.signEnabled, 'true')) }}:
- stage: VMR_Validation
displayName: VMR Validation
dependsOn: VMR_Final_Join
Expand Down
Loading
Loading