Skip to content

[main] Update dependencies from dotnet/runtime #46357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichalStrehovsky merged 4 commits into from
Jan 30, 2025
Merged

[main] Update dependencies from dotnet/runtime #46357

MichalStrehovsky merged 4 commits into from
Jan 30, 2025

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 28, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: cedddd63-79f5-4e7e-6d46-08dc434c4948
  • Build: 20250128.10
  • Date Produced: January 29, 2025 3:01:23 AM UTC
  • Commit: a9d67ec265ed4078265d70d155d06316acadf6fe
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2025…
52acd1c 
…0127.19

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.25073.13 -> To Version 10.0.0-preview.1.25077.19
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Jan 28, 2025
@MichalStrehovsky MichalStrehovsky enabled auto-merge (squash) January 28, 2025 05:37
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jan 28, 2025

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

This was referenced Jan 28, 2025
Open
Closed
Open
Open
Closed
@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 28, 2025

@akoeplinger @maraf looks like the "Microsoft.NET.Sdk.WebAssembly.Pack" nuget package doesn't get produced anymore.

@akoeplinger
Copy link
Member

akoeplinger commented Jan 28, 2025

I think this is correct, it is still being produced in the Browser vertical, but not in the Windows x64 one. This was probably uncovered by the +100 version bump in combination with some refactoring Jeremy did.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 28, 2025 •
edited
Loading

Given that other PRs don't fail with the error (i.e. #46356), it should be one of the incoming changes. Can you please take a look?

Should the package be available on a Windows vertical?

@akoeplinger
Copy link
Member

akoeplinger commented Jan 28, 2025

I think even if that package was there it should still fail while publishing the project since it will be missing the browser-wasm runtime pack which does only get built on the Browser vertical. I'm a bit confused how this worked before.

@akoeplinger
Copy link
Member

akoeplinger commented Jan 28, 2025

Ah yeah it actually says that too in the Test.binlog:

D:\a_work\1\vmr\src\scenario-tests\artifacts\obj\generatedtests\SdkTemplateTest_BlazorWasm_CSharp\SdkTemplateTest_BlazorWasm_CSharp.csproj error NU1102: Unable to find package Microsoft.NETCore.App.Runtime.Mono.browser-wasm with version (= 10.0.0-preview.1.25077.119)

but that still doesn't answer why it works without the changes in this PR...

dotnet-maestro bot and others added 2 commits January 29, 2025 05:02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2025…
561bc8b 
…0128.10

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.25073.13 -> To Version 10.0.0-preview.2.25078.10
@ViktorHofer
Merge branch 'main' into darc-main-09076232-6f81-4695-a5e6-35e378ec1b17
f1188ce
@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 29, 2025 •
edited
Loading

The workload manifest overrides the live version:

image

D:\a_work\1\vmr\artifacts\obj\extracted-dotnet-sdk\sdk-manifests\10.0.100-alpha.1\microsoft.net.workload.mono.toolchain.current\10.0.0-alpha.1.25073.13\WorkloadManifest.targets

The windows vertical doesn't use a live version of microsoft.net.workload.mono.toolchain.current because that doesn't get produced in that vertical and restores an LKG instead. I think that's OK (?).

Side observation: The only reason why this line has the LKG version is because at that point MicrosoftNETCoreAppRefPackageVersion isn't yet overridden with the live value. That is a bug though as it means that the live version is never respected, not even in a vertical that produced the manifest package. We should fix that.

Something now must be changing in this PR that makes the version get updated with the live version.

@ViktorHofer ViktorHofer mentioned this pull request Jan 29, 2025
Open
@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 29, 2025

In the success case (outside of this PR), the following file gets imported:

image

In the failure case (this PR), that import is missing:

image

@build-analysis build-analysis bot mentioned this pull request Jan 29, 2025
Closed
@ViktorHofer ViktorHofer mentioned this pull request Jan 29, 2025
Merged
@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 29, 2025

OK, given that #46389 is successful the diff narrows down to these five commits:

image

Our theory is that the branding update is now somehow causing MAX_PATH issues as alpha -> preview increased the path by 2 characters per version printed. This would be somewhere in the workloads resolver code path.

@akoeplinger
Copy link
Member

akoeplinger commented Jan 29, 2025

We believe we figured out the issue. This code uses the feature band calculated from the SDK version to look for manifests:

sdk/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/SdkDirectoryWorkloadManifestProvider.cs

Lines 319 to 320 in 9a4077f

// Optimization for common case where test hook to add additional directories isn't being used
var manifestVersionBandDirectory = Path.Combine(_manifestRoots[0], _sdkVersionBand.ToString());

However the SDK is still alpha.1 right now so the preview.2 manifests are ignored.

We need to wait for #46346

@MichalStrehovsky MichalStrehovsky merged commit 6bd34bd into main Jan 30, 2025
39 of 42 checks passed
@MichalStrehovsky MichalStrehovsky deleted the darc-main-09076232-6f81-4695-a5e6-35e378ec1b17 branch January 30, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ViktorHofer @akoeplinger @MichalStrehovsky