PGO artifacts are vertical visibility by default except for dotnet-sdk-pgo-* #46063
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,6 +98,8 @@ | |
| <BuildArgs>$(BuildArgs) /p:SourceBuiltAssetManifestsDir=$(RepoAssetManifestsDir)</BuildArgs> | ||
| <BuildArgs Condition="'$(OfficialBuildId)' != ''">$(BuildArgs) /p:OfficialBuildId=$(OfficialBuildId)</BuildArgs> | ||
| <BuildArgs Condition="'$(ForceDryRunSigning)' != ''">$(BuildArgs) /p:ForceDryRunSigning=$(ForceDryRunSigning)</BuildArgs> | ||
| <!-- PGO assets by default are "Vertical" visibilty. Each repo will enable the specific artifacts it must publish externally --> | ||
| <BuildArgs Condition="'$(PgoInstrument)' == 'true'">$(BuildArgs) /p:DefaultArtifactVisibility=Vertical</BuildArgs> | ||
|
Member
There was a problem hiding this comment. @ViktorHofer @jkoritzinsky Is your thinking that default artifact visibility is something that the VMR will be responsible for passing, rather than runtime setting this under certain conditions?
Member
Author
There was a problem hiding this comment. I think the default visibility should be a property of the VMR for PGO as we need to tell every repo (not just runtime) that its assets are Vertical-only. For other scenarios (like filtering out RID-agnostic packages if we wanted to get rid of the concept of a main vertical entirely) I could see runtime controlling the default rules itself. |
||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(DotNetBuildSourceOnly)' == 'true'"> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| From 62c4b5f114850d39efdca3df3b9ee83cc0f424ff Mon Sep 17 00:00:00 2001 | ||
| From: Jeremy Koritzinsky <jekoritz@microsoft.com> | ||
| Date: Tue, 21 Jan 2025 16:16:49 -0800 | ||
| Subject: [PATCH 1/2] Use the documented Artifact extension point to add | ||
| artifacts | ||
|
|
||
| The Artifact extension point handles symbol packages automatically for source-build, and it automatically gets support for new features like Artifact Visibility (required for https://github.com/dotnet/sdk/pull/46063) | ||
| Backport: https://github.com/NuGet/NuGet.Client/pull/6233 | ||
| --- | ||
| eng/Publishing.props | 11 +++-------- | ||
| 1 file changed, 3 insertions(+), 8 deletions(-) | ||
|
|
||
| diff --git a/eng/Publishing.props b/eng/Publishing.props | ||
| index 38810c73428..1175200dd59 100644 | ||
| --- a/eng/Publishing.props | ||
| +++ b/eng/Publishing.props | ||
| @@ -1,11 +1,6 @@ | ||
| <Project> | ||
| - | ||
| <ItemGroup> | ||
| - <ItemsToPushToBlobFeed Include="$(ArtifactsDir)nupkgs/*.nupkg" | ||
| - IsShipping="true" | ||
| - UploadPathSegment="nuget-client" /> | ||
| - <_SymbolsPackages Include="$(ArtifactsDir)nupkgs/*.symbols.nupkg" /> | ||
| - <ItemsToPushToBlobFeed Remove="@(_SymbolsPackages)" Condition="'$(DotNetBuildSourceOnly)' == 'true'" /> | ||
| + <Artifact Include="$(ArtifactsDir)nupkgs/*.nupkg" | ||
| + IsShipping="true" /> | ||
| </ItemGroup> | ||
| - | ||
| -</Project> | ||
| \ No newline at end of file | ||
| +</Project> | ||
|
|
||
| From 9072cb03cb5c2958df318f59389547caa5de2c8a Mon Sep 17 00:00:00 2001 | ||
| From: Jeremy Koritzinsky <jkoritzinsky@gmail.com> | ||
| Date: Wed, 22 Jan 2025 10:07:47 -0800 | ||
| Subject: [PATCH 2/2] Formatting and PR feedback | ||
|
|
||
| --- | ||
| eng/Publishing.props | 14 ++++++++------ | ||
| 1 file changed, 8 insertions(+), 6 deletions(-) | ||
|
|
||
| diff --git a/eng/Publishing.props b/eng/Publishing.props | ||
| index 1175200dd59..41f498d4d4a 100644 | ||
| --- a/eng/Publishing.props | ||
| +++ b/eng/Publishing.props | ||
| @@ -1,6 +1,8 @@ | ||
| -<Project> | ||
| - <ItemGroup> | ||
| - <Artifact Include="$(ArtifactsDir)nupkgs/*.nupkg" | ||
| - IsShipping="true" /> | ||
| - </ItemGroup> | ||
| -</Project> | ||
| +<Project> | ||
| + | ||
| + <ItemGroup> | ||
| + <Artifact Include="$(ArtifactsDir)nupkgs/*.nupkg" | ||
| + PublishFlatContainer="false" /> | ||
| + </ItemGroup> | ||
| + | ||
| +</Project> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.