Skip to content

Remove the spacing from the table header of the templating new tests #46000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Remove the spacing from the table header of the templating new tests #46000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3aa8c4
Figuring out the spaces required in the table header is really hard w…
marcpopMSFT Jan 15, 2025
953a20f
Remove the dashes and include the Template name header
marcpopMSFT Jan 15, 2025
696116b
fix style issue
marcpopMSFT Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../Approvals/DotnetNewListTests.BasicTest_WhenLegacyCommandIsUsed_common.Linux.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
For more information, run:
dotnet new list -h
These templates matched your input:
Template Name Short Name Language Tags
Template
API
ASP.NET
Blazor
Expand Down
2 changes: 1 addition & 1 deletion ...ts/Approvals/DotnetNewListTests.BasicTest_WhenLegacyCommandIsUsed_common.OSX.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
For more information, run:
dotnet new list -h
These templates matched your input:
Template Name Short Name Language Tags
Template
API
ASP.NET
Blazor
Expand Down
2 changes: 1 addition & 1 deletion ...pprovals/DotnetNewListTests.BasicTest_WhenLegacyCommandIsUsed_common.Windows.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
For more information, run:
dotnet new list -h
These templates matched your input:
Template Name Short Name Language Tags
Template
API
ASP.NET
Blazor
Expand Down
2 changes: 1 addition & 1 deletion ...new.Tests/Approvals/DotnetNewListTests.BasicTest_WhenListCommandIsUsed.Linux.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
These templates matched your input:
Template Name Short Name Language Tags
Template
API
ASP.NET
Blazor
Expand Down
2 changes: 1 addition & 1 deletion ...t-new.Tests/Approvals/DotnetNewListTests.BasicTest_WhenListCommandIsUsed.OSX.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
These templates matched your input:
Template Name Short Name Language Tags
Template
API
ASP.NET
Blazor
Expand Down
2 changes: 1 addition & 1 deletion ...w.Tests/Approvals/DotnetNewListTests.BasicTest_WhenListCommandIsUsed.Windows.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
These templates matched your input:
Template Name Short Name Language Tags
Template
API
ASP.NET
Blazor
Expand Down
10 changes: 8 additions & 2 deletions test/dotnet-new.Tests/DotnetNewListTests.Approval.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Licensed to the .NET Foundation under one or more agreements.
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using Microsoft.DotNet.Cli.Utils;
Expand Down Expand Up @@ -57,9 +57,15 @@ private static void ScrubData(StringBuilder input)

foreach (var line in lines)
{
if (line.StartsWith("-----"))
// start trimming whitespace and anything but the first word with the start of the table
if (line.StartsWith("Template Name", StringComparison.Ordinal))
{
isTable = true;
}

// We don't want to have to count how many dashes are in the table separator as this can change based on the width of the column
if (line.StartsWith("-----", StringComparison.Ordinal))
{
continue;
}

Expand Down
Loading