Use the new DotNetBuildAllRuntimePacks property in dotnet/runtime build to collapse legs #45932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
Author
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…remove 36 VMR legs. Remove support for the following properties as we no longer have separate ShortStack legs for them: - DotNetBuildRuntimeNativeAOTRuntimePack - DotNetBuildMonoCrossAOT Continue to support DotNetBuildUseMonoRuntime to specify mono-only builds as that will still be used by the Mono LLVMAOT VMR legs and we can still use it to validate Mono-only SB targets on non-Mono-only systems (ie validate the s390x build experience on x64)
jkoritzinsky
force-pushed
the
vmr-build-all-runtime-packs
branch
from
6ac3a58 to
1ffaaf7
Compare
This was referenced Jan 13, 2025
Member
|
Sorry I accidentally hit the "Ready for review" button. |
Member
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Still disk space issues, damn. In the Sign.proj stage. |
This was referenced Jan 22, 2025
Member
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Looks better now. FWIW I see running out of disk space issues in other PRs as well, i.e. on short stack legs. I think there are some low hanging fruits how to make this better that we can and should follow-up post-merge. I don't think that we should block this PR on that though if the builds are green now. |
Member
Author
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 23, 2025
baronfel
pushed a commit
to baronfel/sdk
that referenced
this pull request
Feb 24, 2025
…ld to collapse legs (dotnet#45932)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we can remove 36 VMR legs.
Remove support for the following properties as we no longer have separate ShortStack legs for them:
Continue to support DotNetBuildUseMonoRuntime to specify mono-only builds as that will still be used by the Mono LLVMAOT VMR legs and we can still use it to validate Mono-only SB targets on non-Mono-only systems (ie validate the s390x build experience on x64)
Contributes to dotnet/source-build#4770
Contributes to dotnet/source-build#4648