Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dotnet-watch tests TFM agnostic #44604

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Make dotnet-watch tests TFM agnostic #44604

merged 3 commits into from
Nov 3, 2024

Conversation

am11
Copy link
Member

@am11 am11 commented Nov 2, 2024

next thing to unblock #43015

�[m�[37m      'dotnet watch ⚠ [WatchHotReloadApp (net9.0)] Exception from 'System.Action`1[System.Type[]]': System.InvalidOperationException: Bug!' not found in:
...
37m      'dotnet watch ⚠ [WatchHotReloadApp (net10.0)] Exception from 'System.Action`1[System.Type[]]': System.InvalidOperationException: Bug!'
�[m�[37m      '   at AppUpdateHandler.ClearCache(Type[] types)'

@am11 am11 requested review from tmat and a team as code owners November 2, 2024 17:31
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 2, 2024
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works. Personally, I would have passed the watcher TFM in as an assembly attribute or a runtimeconfig entry to assert on the exact TFM but this way is fine.

Thank you!

@am11
Copy link
Member Author

am11 commented Nov 2, 2024

Lets rerun the failed legs. (one timed out, other one failed to delete a directory)

@ViktorHofer ViktorHofer enabled auto-merge (squash) November 2, 2024 20:38
auto-merge was automatically disabled November 2, 2024 21:03

Head branch was pushed to by a user without write access

@ViktorHofer ViktorHofer enabled auto-merge (squash) November 2, 2024 21:42
@ViktorHofer ViktorHofer merged commit 2d9a8cc into dotnet:main Nov 3, 2024
37 checks passed
@am11 am11 deleted the patch-2 branch November 3, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants