Browser refresh and WASM delta applier refactoring #44539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-AspNetCore
|
Thanks for your PR, @tmat. |
tmat
force-pushed
the
WasmApplierRefactoring
branch
2 times, most recently
from
f0fabb8 to
06c7824
Compare
|
@tlmii @phil-allen-msft ptal |
tmat
force-pushed
the
WasmApplierRefactoring
branch
from
06c7824 to
71d3256
Compare
This was referenced Nov 1, 2024
tmat
force-pushed
the
WasmApplierRefactoring
branch
from
71d3256 to
3b6e0a8
Compare
| @@ -8,10 +8,12 @@ export function receiveHotReload() { | |||
| export async function receiveHotReloadAsync() { | |||
| const response = await fetch('/_framework/blazor-hotreload'); | |||
There was a problem hiding this comment.
Can you think of any way in which the implementor of _framework/blazor-hotreload is from a different SDK version but this injected JS code?
There was a problem hiding this comment.
I don't think that will be a problem. We can remove this once we migrate ASP.NET to the newer API and insert it into the SDK. This is temporary so that we can make the changes incrementally.
phil-allen-msft
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves browser connection management and delta application to WASM.
Includes PDB delta in the update payload.
Sends logs from the client back to dotnet-watch.
Prepares agent code for sharing with ASP.NET.
Fixes issues with delta application when multiple browsers are connected to the same dev server.