Skip to content

Update SystemTextJsonToolsetPackageVersion #44029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update SystemTextJsonToolsetPackageVersion #44029

wants to merge 3 commits into from

Conversation

am11
Copy link
Member

@am11 am11 commented Oct 9, 2024

cc @MichaelSimons just fixed this in runtime dotnet/runtime#108704. (being proactive) :D

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Oct 9, 2024
@build-analysis build-analysis bot mentioned this pull request Oct 9, 2024
Open
3 tasks
@am11 am11 mentioned this pull request Oct 10, 2024
Merged
ViktorHofer
ViktorHofer requested changes Oct 14, 2024
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS hasn't yet shipped with updated binding redirects for STJ/8.0.0.5. That change got merged 6 days ago: dotnet/msbuild@eacead3#diff-2c2e83275077d3c65c1190f9aabc894271ab22132b4f5675f16fb1301c0639d8

@ViktorHofer
Copy link
Member

cc @rainersigwald

@am11
Copy link
Member Author

am11 commented Oct 14, 2024

Or maybe just apply/cherry-pick on #44011

@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 14, 2024 •
edited
Loading

I mean that we usually have to wait around two months until our windows CI clients have a VS installed with the updated binding redirects for .NET Framework msbuild.

@am11
Copy link
Member Author

am11 commented Oct 14, 2024

I mean that we usually have to wait around two months until our windows CI clients have a VS installed with the updated binding redirects for .NET Framework msbuild.

Ah ok, lets close this one until that happen. FWIW, this was a CVE fix which started breaking builds last week (and this is the fourth PR of the kind runtime,diagnostics,msbuild are already on 8.0.5).

@am11 am11 closed this Oct 14, 2024
@am11 am11 deleted the patch-2 branch October 14, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer requested changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@am11 @ViktorHofer